Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panel content not scrolling and footer not showing with shell panel display-mode="float" #8611

Closed
2 of 6 tasks
COV-GIS opened this issue Jan 16, 2024 · 2 comments
Closed
2 of 6 tasks
Assignees
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 5 A few days of work, definitely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality regression Issues that are caused by changes in a release, but were working before that. testing Issues related to automated or manual testing.

Comments

@COV-GIS
Copy link

COV-GIS commented Jan 16, 2024

Check existing issues

Actual Behavior

As of 2.x overflow panel content is not scrolling and footer is not positioned to the bottom . See sample.

image

Expected Behavior

Panel content to scroll and the footer to be visible.

image

Reproduction Sample

https://codepen.io/COV-GIS/pen/dyrvbQb

Reproduction Steps

As shown in sample.

Optionally switch display-mode between float and dock.

Reproduction Version

2.x

Relevant Info

No response

Regression?

1.x

Priority impact

p2 - want for current milestone

Impact

Unable to update apps to 2.x until this is resolved.

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

N/A

@COV-GIS COV-GIS added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Jan 16, 2024
@github-actions github-actions bot added impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone calcite-components Issues specific to the @esri/calcite-components package. labels Jan 16, 2024
@geospatialem geospatialem added testing Issues related to automated or manual testing. regression Issues that are caused by changes in a release, but were working before that. p - high Issue should be addressed in the current milestone, impacts component or core functionality estimate - 3 A day or two of work, likely requires updates to tests. estimate - 5 A few days of work, definitely requires updates to tests. and removed estimate - 3 A day or two of work, likely requires updates to tests. labels Feb 7, 2024
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Feb 7, 2024
@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label Feb 7, 2024
@geospatialem geospatialem added the ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. label Feb 9, 2024
driskull added a commit that referenced this issue Feb 13, 2024
**Related Issue:** #8028 #8611

## Summary

- Reverts previous pull request which removes `overflow:hidden` on the
host of the `panel` and `flow-item` components.
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Feb 13, 2024
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Feb 15, 2024
@geospatialem
Copy link
Member

Verified in 2.5.0-next.6:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 5 A few days of work, definitely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality regression Issues that are caused by changes in a release, but were working before that. testing Issues related to automated or manual testing.
Projects
None yet
Development

No branches or pull requests

4 participants