-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[calcite-loader] Allow a way to display percent sign on the determinate value #8678
Comments
This issue is now impacting us in ArcGIS Online. We would really like this enhancement before the fall release of ArcGIS Online if at all possible. |
For design expertise 🧠 : Should we also support the |
Discussed the above with Skye, where they recommend the following:
|
Would like to propose closing in favor of 4470, where we are exploring renaming the current Loader type value to |
@SkyeSeitz - I'm not quite clear on the meaning of your comment. I took a look at #8735 you referenced, but didn't see anything that has to do with the number labeling. Will the new solution you are proposing allow the user of |
Apologies, @rpanichakit9541! It looks like we can address adding the percentage sign in this issue. Easy addition with only one font-size adjustment needed to fit the extra "%" character at the small scale (outlined below). We can add this percentage affordance as a new value to the type property. Link to Figma file: https://www.figma.com/design/7BIhM7Anfkp0pdv03cFfFg/%5BLoader%5D-percent-sign?node-id=1-2&t=rxtPGEZmxgSjeQUA-11 |
Note that there will be a minor visual change for small scale, determinate loaders. |
**Related Issue:** #8678 ## Summary Adds new determinate type to allow users to opt-into displaying the progress (percent) label. **Note:** the current `determinate` type will no longer display a label in a future release.
Installed and assigned for verification. |
Additional note: the current |
🍡 Verified on |
Check existing issues
Description
Currently the value of the determinate loader just displays as a number which the user can mistake as the count number of items done instead of the percentage of completion. This is a request to be able to set a prop to tell the calcite-loader component to display the percent sign next to the number value.
Acceptance Criteria
The user should be able to set a prop on the calcite-loader component to tell it to display a percent sign next to the percent value
Relevant Info
No response
Which Component
calcite-loader
Example Use Case
No response
Priority impact
p4 - not time sensitive
Calcite package
Esri team
ArcGIS Online
The text was updated successfully, but these errors were encountered: