Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[calcite-loader] Allow a way to display percent sign on the determinate value #8678

Closed
2 of 6 tasks
rpanichakit9541 opened this issue Jan 31, 2024 · 11 comments
Closed
2 of 6 tasks
Assignees
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Online Issues logged by ArcGIS Online team members. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 2 Small fix or update, may require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library ready for dev Issues ready for development implementation. visual changes Issues with visual changes that are added for consistency, but are not backwards compatible.

Comments

@rpanichakit9541
Copy link
Contributor

Check existing issues

Description

Currently the value of the determinate loader just displays as a number which the user can mistake as the count number of items done instead of the percentage of completion. This is a request to be able to set a prop to tell the calcite-loader component to display the percent sign next to the number value.

Acceptance Criteria

The user should be able to set a prop on the calcite-loader component to tell it to display a percent sign next to the percent value

Relevant Info

No response

Which Component

calcite-loader

Example Use Case

No response

Priority impact

p4 - not time sensitive

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Online

@rpanichakit9541 rpanichakit9541 added 0 - new New issues that need assignment. enhancement Issues tied to a new feature or request. needs triage Planning workflow - pending design/dev review. labels Jan 31, 2024
@github-actions github-actions bot added ArcGIS Online Issues logged by ArcGIS Online team members. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive calcite-components Issues specific to the @esri/calcite-components package. labels Jan 31, 2024
@mpriour
Copy link
Member

mpriour commented Jun 6, 2024

This issue is now impacting us in ArcGIS Online. We would really like this enhancement before the fall release of ArcGIS Online if at all possible.

@geospatialem geospatialem added design Issues that need design consultation prior to development. estimate - 2 Small fix or update, may require updates to tests. labels Jun 10, 2024
@geospatialem
Copy link
Member

geospatialem commented Jun 10, 2024

For design expertise 🧠 : Should we also support the "%" when the value is 100?

@geospatialem geospatialem added this to the 2024-08-27 - Aug Release milestone Jun 10, 2024
@geospatialem geospatialem added p - medium Issue is non core or affecting less that 60% of people using the library and removed needs triage Planning workflow - pending design/dev review. labels Jun 10, 2024
@geospatialem
Copy link
Member

Discussed the above with Skye, where they recommend the following:

We should always display the percentage for the value, even when the value is at 100%. However, it is recommended once the component reaches 100% to remove the loading state.

Additionally, in looking at other design systems, which use a circular progress similar to our determinate loader, it is common to not have the percentage by default, so we should explore adding the percentage as a new property.

Resources:

@geospatialem geospatialem added the ready for dev Issues ready for development implementation. label Jun 10, 2024
@github-actions github-actions bot added the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Jun 10, 2024
@github-actions github-actions bot removed this from the 2024-08-27 - Aug Release milestone Jun 10, 2024
Copy link
Contributor

cc @geospatialem, @brittneytewks

@geospatialem geospatialem added this to the 2024-08-27 - Aug Release milestone Jun 10, 2024
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Jun 10, 2024
@jcfranco jcfranco self-assigned this Aug 2, 2024
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Aug 2, 2024
@SkyeSeitz
Copy link

SkyeSeitz commented Aug 12, 2024

Would like to propose closing in favor of 4470, where we are exploring renaming the current Loader type value to determinate-numeric which displays a number out of 100 (there was not sufficient space to warrant adding a percentage suffix) and adding an additional Loader type value that is just determinate, which removes the number to avoid confusion.
image

@rpanichakit9541
Copy link
Contributor Author

@SkyeSeitz - I'm not quite clear on the meaning of your comment. I took a look at #8735 you referenced, but didn't see anything that has to do with the number labeling. Will the new solution you are proposing allow the user of calcite-loader to be able to label it with a percent sign?

@SkyeSeitz
Copy link

Apologies, @rpanichakit9541! It looks like we can address adding the percentage sign in this issue. Easy addition with only one font-size adjustment needed to fit the extra "%" character at the small scale (outlined below).
image

We can add this percentage affordance as a new value to the type property.
image

Link to Figma file: https://www.figma.com/design/7BIhM7Anfkp0pdv03cFfFg/%5BLoader%5D-percent-sign?node-id=1-2&t=rxtPGEZmxgSjeQUA-11

@jcfranco jcfranco added the visual changes Issues with visual changes that are added for consistency, but are not backwards compatible. label Aug 16, 2024
@jcfranco
Copy link
Member

Note that there will be a minor visual change for small scale, determinate loaders.

jcfranco added a commit that referenced this issue Aug 19, 2024
**Related Issue:** #8678

## Summary

Adds new determinate type to allow users to opt-into displaying the
progress (percent) label.

**Note:** the current `determinate` type will no longer display a label
in a future release.
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Aug 19, 2024
Copy link
Contributor

Installed and assigned for verification.

@jcfranco
Copy link
Member

Additional note: the current determinate type will no longer display a label in a future release.

@DitwanP
Copy link
Contributor

DitwanP commented Aug 20, 2024

🍡 Verified on 2.12.0-next.26
https://codepen.io/Ditwan-Price/pen/zYVWvEB

@DitwanP DitwanP closed this as completed Aug 20, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Online Issues logged by ArcGIS Online team members. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 2 Small fix or update, may require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library ready for dev Issues ready for development implementation. visual changes Issues with visual changes that are added for consistency, but are not backwards compatible.
Projects
None yet
Development

No branches or pull requests

6 participants