Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nesting Lists inside List Items removes the bottom border between items #8684

Closed
2 of 6 tasks
ashetland opened this issue Feb 1, 2024 · 2 comments
Closed
2 of 6 tasks

Nesting Lists inside List Items removes the bottom border between items #8684

ashetland opened this issue Feb 1, 2024 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests.
Milestone
2024-02-15 - Feb ...

Comments

@ashetland
Copy link

Check existing issues

Actual Behavior

When a list is slotted into a list-item the parent list-item loses its bottom border.
CleanShot 2024-02-01 at 12 48 14@2x

Expected Behavior

I would expect the bottom border to be present on all items.

Reproduction Sample

https://codepen.io/ashetland/pen/QWoQvVr?editors=1000

Reproduction Steps

Compare the nesting of Lists vs List Items in the example.

Reproduction Version

v2.4.0

Relevant Info

No response

Regression?

No response

Priority impact

p3 - want for upcoming milestone

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (design)
@ashetland ashetland added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Feb 1, 2024
@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. Calcite (design) Issues logged by Calcite designers. p3 - want for upcoming milestone labels Feb 1, 2024
driskull added a commit that referenced this issue Feb 9, 2024
@driskull
fix(list-item): Fix slotted list border styling. #8684
adccbd7
@driskull driskull self-assigned this Feb 9, 2024
@driskull driskull added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Feb 9, 2024
@driskull driskull added estimate - 2 Small fix or update, may require updates to tests. and removed needs triage Planning workflow - pending design/dev review. labels Feb 9, 2024
@driskull driskull mentioned this issue Feb 9, 2024
Merged
driskull added a commit that referenced this issue Feb 9, 2024
@driskull
fix(list-item): Fix slotted list border styling. (#8712)
855f98d 
**Related Issue:** #8684

## Summary

- Updates slotted styling for list elements.
- Adds screenshot test
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Feb 9, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned driskull Feb 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 9, 2024

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Feb 13, 2024
@geospatialem
Copy link
Member

Verified in 2.5.0-next.2:

image

Elijbet pushed a commit that referenced this issue Feb 15, 2024
@driskull @Elijbet
fix(list-item): Fix slotted list border styling. (#8712)
f911407 
**Related Issue:** #8684

## Summary

- Updates slotted styling for list elements.
- Adds screenshot test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests.
Projects
None yet
Milestone
2024-02-15 - Feb Maintenance Release
Development

No branches or pull requests
4 participants
@driskull @geospatialem @DitwanP @ashetland