Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Block] Where no heading is defined the component adds spacing #9753

Closed
2 of 6 tasks
geospatialem opened this issue Jul 10, 2024 · 2 comments
Closed
2 of 6 tasks

[Block] Where no heading is defined the component adds spacing #9753

geospatialem opened this issue Jul 10, 2024 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. has workaround Issues have a workaround available in the meantime. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality regression Issues that are caused by changes in a release, but were working before that.
Milestone
2024-07-31 - Jul ...

Comments

@geospatialem
Copy link
Member

geospatialem commented Jul 10, 2024 •
edited
Loading

Check existing issues

Actual Behavior

When a block is specified without a heading the component contains spacing, which was not present in the 2.9.0 release.

image

Expected Behavior

The same behavior depicted in 2.9.0: https://codepen.io/driskull/pen/poXvddG

image

Reproduction Sample

https://codepen.io/driskull/pen/wvLBPPj

Reproduction Steps

  1. Open the sample with 2.10.1
  2. Observe the spacing
  3. Open the sample with 2.9.0
  4. Observe the spacing

Reproduction Version

2.10.1

Relevant Info

Possibly related to https://github.com/Esri/calcite-design-system/pull/9535/files#diff-153092ac5984c89017b0d1b44791101b55a8a9272dec6d47a6bd4063f0427499R24 from #9535

Regression?

2.9.0

Priority impact

impact - p1 - need for current milestone

Impact

Effects the Maps SDK for JavaScript editor

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Maps SDK for JavaScript
@geospatialem geospatialem added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. p - high Issue should be addressed in the current milestone, impacts component or core functionality 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. regression Issues that are caused by changes in a release, but were working before that. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. estimate - 3 A day or two of work, likely requires updates to tests. labels Jul 10, 2024
@geospatialem geospatialem added this to the 2024-07-30 - Jul Release milestone Jul 10, 2024
@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label Jul 10, 2024
@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone labels Jul 10, 2024
@geospatialem geospatialem added the has workaround Issues have a workaround available in the meantime. label Jul 10, 2024
@aPreciado88 aPreciado88 self-assigned this Jul 15, 2024
@aPreciado88 aPreciado88 added 1 - assigned Issues that are assigned to a sprint and a team member. 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. 1 - assigned Issues that are assigned to a sprint and a team member. labels Jul 15, 2024
@aPreciado88 aPreciado88 mentioned this issue Jul 15, 2024
Merged
aPreciado88 added a commit that referenced this issue Jul 15, 2024
@aPreciado88
fix(block): remove top padding when no heading is defined (#9782)
d71e064 
**Related Issue:**
[#9753](#9753)

## Summary
Updates component to have no top padding when `heading` is not defined.
@aPreciado88 aPreciado88 added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jul 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned aPreciado88 Jul 15, 2024
@DitwanP
Copy link
Contributor

DitwanP commented Jul 16, 2024 •
edited
Loading

🍡 Verified locally on dev

Box model in 2.10.1 (unwanted padding):
Screenshot 2024-07-15 at 5 14 40 PM

Box model of the header element (notice no unwanted padding) 👌:
Screenshot 2024-07-15 at 5 11 09 PM

@DitwanP DitwanP closed this as completed Jul 16, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jul 16, 2024
calcite-admin pushed a commit that referenced this issue Jul 30, 2024
@aPreciado88 @github-actions
fix(block): remove top padding when no heading is defined (#9782)
704f5df 
**Related Issue:**
[#9753](#9753)

## Summary
Updates component to have no top padding when `heading` is not defined.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. has workaround Issues have a workaround available in the meantime. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality regression Issues that are caused by changes in a release, but were working before that.
Projects
None yet
Milestone
2024-07-31 - Jul Release
Development

No branches or pull requests
3 participants
@geospatialem @DitwanP @aPreciado88