Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

panel: add alerts slot #9772

Closed
2 of 6 tasks
driskull opened this issue Jul 12, 2024 · 10 comments
Closed
2 of 6 tasks

panel: add alerts slot #9772

driskull opened this issue Jul 12, 2024 · 10 comments
Assignees
Labels
4 - verified Issues that have been released and confirmed resolved. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. estimate - 3 A day or two of work, likely requires updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality

Comments

@driskull
Copy link
Member

Check existing issues

Description

add alerts slot to panel to constrain alerts to the panel in question

Acceptance Criteria

alerts can be slotted into a panel and contained within that panel

Relevant Info

#7886 (comment)

Which Component

panel

Example Use Case

<calcite-panel>
<calcite-alert slot="alerts"></calcite-alert>
</calcite-panel>

Priority impact

impact - p1 - need for current milestone

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

N/A

@driskull driskull added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jul 12, 2024
@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone labels Jul 12, 2024
@jcfranco jcfranco added p - high Issue should be addressed in the current milestone, impacts component or core functionality estimate - 3 A day or two of work, likely requires updates to tests. labels Jul 12, 2024
@jcfranco jcfranco added this to the 2024-07-30 - Jul Release milestone Jul 12, 2024
@jcfranco jcfranco added 1 - assigned Issues that are assigned to a sprint and a team member. and removed needs triage Planning workflow - pending design/dev review. 0 - new New issues that need assignment. labels Jul 12, 2024
driskull added a commit that referenced this issue Jul 15, 2024
driskull added a commit that referenced this issue Jul 16, 2024
**Related Issue:** #9772

## Summary

- add `alerts` slot to `panel` and `flow-item`
- rename existing internal property `slottedInShell` to `embedded` for
greater use beyond just shell
- add e2e test
- add screenshot tests
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Jul 16, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned driskull Jul 16, 2024
Copy link
Contributor

Installed and assigned for verification.

@DitwanP
Copy link
Contributor

DitwanP commented Jul 16, 2024

@driskull Is this how it's intended to look or is it supposed to be above the buttons?
Screenshot 2024-07-16 at 10 59 06 AM

@driskull
Copy link
Member Author

Yes, that is how I intended, it is just constrained inside the panel. Maybe we should ask @SkyeSeitz and @ashetland ?

@SkyeSeitz
Copy link

Is the Alert slot always tied to the content inside the bounds of Panel's default slot? Or would that ever be too narrow?
image

@driskull
Copy link
Member Author

My thinking was that it might be too narrow in some cases.

@SkyeSeitz
Copy link

I assumed the same and defaulted to positioned to the Panel itself. I am fine with that if no one else has any objections.

@ashetland
Copy link

This may be fine as a starting point and could be updated after feedback. My initial reaction is it does feel awkward covering the footer like that and might be nice if it had some margin to force it higher? But as I said, could wait for feedback on it.

@driskull
Copy link
Member Author

Let me know what you prefer. I can make it appear over the content if that's the way we want to go.

@ashetland
Copy link

"Wait for feedback" is the consensus. ✅

@DitwanP
Copy link
Contributor

DitwanP commented Jul 16, 2024

🍡Verified on 2.11.0-next.11

@DitwanP DitwanP closed this as completed Jul 16, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jul 16, 2024
calcite-admin pushed a commit that referenced this issue Jul 30, 2024
**Related Issue:** #9772

## Summary

- add `alerts` slot to `panel` and `flow-item`
- rename existing internal property `slottedInShell` to `embedded` for
greater use beyond just shell
- add e2e test
- add screenshot tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - verified Issues that have been released and confirmed resolved. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. estimate - 3 A day or two of work, likely requires updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality
Projects
None yet
Development

No branches or pull requests

6 participants