-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
panel: add alerts slot #9772
Comments
**Related Issue:** #9772 ## Summary - add `alerts` slot to `panel` and `flow-item` - rename existing internal property `slottedInShell` to `embedded` for greater use beyond just shell - add e2e test - add screenshot tests
Installed and assigned for verification. |
@driskull Is this how it's intended to look or is it supposed to be above the buttons? |
Yes, that is how I intended, it is just constrained inside the panel. Maybe we should ask @SkyeSeitz and @ashetland ? |
My thinking was that it might be too narrow in some cases. |
I assumed the same and defaulted to positioned to the Panel itself. I am fine with that if no one else has any objections. |
This may be fine as a starting point and could be updated after feedback. My initial reaction is it does feel awkward covering the footer like that and might be nice if it had some margin to force it higher? But as I said, could wait for feedback on it. |
Let me know what you prefer. I can make it appear over the content if that's the way we want to go. |
"Wait for feedback" is the consensus. ✅ |
🍡Verified on |
**Related Issue:** #9772 ## Summary - add `alerts` slot to `panel` and `flow-item` - rename existing internal property `slottedInShell` to `embedded` for greater use beyond just shell - add e2e test - add screenshot tests
Check existing issues
Description
add alerts slot to panel to constrain alerts to the panel in question
Acceptance Criteria
alerts can be slotted into a panel and contained within that panel
Relevant Info
#7886 (comment)
Which Component
panel
Example Use Case
Priority impact
impact - p1 - need for current milestone
Calcite package
Esri team
N/A
The text was updated successfully, but these errors were encountered: