Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Combobox] placeholder icon color does not match other components #9935

Closed
2 of 6 tasks
ashetland opened this issue Aug 1, 2024 · 2 comments
Closed
2 of 6 tasks

[Combobox] placeholder icon color does not match other components #9935

ashetland opened this issue Aug 1, 2024 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - low Issue is non core or affecting less that 10% of people using the library
Milestone
2024-08-27 - Aug ...

Comments

@ashetland
Copy link
Contributor

Check existing issues

Actual Behavior

The placeholder icon is black.

Expected Behavior

The placeholder icon should be text.3.

Reproduction Sample

https://codepen.io/ashetland/pen/mdZWLwz

Reproduction Steps

See that Input Time Picker and Input Date Picker use text.3

Reproduction Version

v2.10.1

Relevant Info

No response

Regression?

No response

Priority impact

impact - p3 - not time sensitive

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (design)
@ashetland ashetland added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Aug 1, 2024
@github-actions github-actions bot added Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Aug 1, 2024
@jcfranco jcfranco self-assigned this Aug 2, 2024
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. p - low Issue is non core or affecting less that 10% of people using the library and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Aug 2, 2024
@jcfranco jcfranco added this to the 2024-08-27 - Aug Release milestone Aug 2, 2024
@jcfranco jcfranco mentioned this issue Aug 2, 2024
Merged
jcfranco added a commit that referenced this issue Aug 5, 2024
@jcfranco
fix(combobox): update placeholder-icon color (#9956)
d916ca4 
**Related Issue:** #9935

## Summary

This updates the placeholder's icon color to be consistent with other
components.
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Aug 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 5, 2024

Installed and assigned for verification.

@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned jcfranco Aug 5, 2024
@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Aug 6, 2024
@geospatialem
Copy link
Member

Verified in 2.12.0-next.5:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - low Issue is non core or affecting less that 10% of people using the library
Projects
None yet
Milestone
2024-08-27 - Aug Release
Development

No branches or pull requests
4 participants
@jcfranco @geospatialem @DitwanP @ashetland