Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color picker text gets highlighted #9977

Closed
2 of 6 tasks
nel11211 opened this issue Aug 6, 2024 · 3 comments
Closed
2 of 6 tasks

Color picker text gets highlighted #9977

nel11211 opened this issue Aug 6, 2024 · 3 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Charts Issues logged by ArcGIS Charts team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - high Issue should be addressed in the current milestone, impacts component or core functionality regression Issues that are caused by changes in a release, but were working before that.
Milestone
2024-08-27 - Aug ...

Comments

@nel11211
Copy link

nel11211 commented Aug 6, 2024 •
edited
Loading

Check existing issues

Actual Behavior

Color picker text gets highlighted when dragging cursor over during color selection.

Expected Behavior

When the user is dragging the color picker around the swatch, it should not also highlight the text when it gets waved over. 2.10.1 has the expected behavior.

Reproduction Sample

https://codepen.io/nel11211/pen/ExBXeLy?editors=1000

calcite-color-picker-text-selection-bug

Reproduction Steps

  1. In a calcite-color-picker component, click and drag in the swatch to select a color.
  2. Drag cursor outside and below the color picker.
  3. Text gets highlighted.

Reproduction Version

2.11.1

Relevant Info

Regression (bug not seen on 2.10.1):

calcite-color-picker-text-selection-before

Regression?

2.10.1

Priority impact

impact - p3 - not time sensitive

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Charts
@nel11211 nel11211 added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Aug 6, 2024
@github-actions github-actions bot added ArcGIS Charts Issues logged by ArcGIS Charts team members. calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Aug 6, 2024
@geospatialem geospatialem added the regression Issues that are caused by changes in a release, but were working before that. label Aug 7, 2024
@geospatialem
Copy link
Member

Possibly related to b2be625

@geospatialem geospatialem added p - high Issue should be addressed in the current milestone, impacts component or core functionality estimate - 2 Small fix or update, may require updates to tests. and removed needs triage Planning workflow - pending design/dev review. labels Aug 7, 2024
@geospatialem geospatialem added this to the 2024-08-27 - Aug Release milestone Aug 12, 2024
@jcfranco jcfranco self-assigned this Aug 12, 2024
@jcfranco jcfranco added 1 - assigned Issues that are assigned to a sprint and a team member. 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. 1 - assigned Issues that are assigned to a sprint and a team member. labels Aug 12, 2024
@jcfranco jcfranco mentioned this issue Aug 12, 2024
Merged
jcfranco added a commit that referenced this issue Aug 13, 2024
@jcfranco
fix(color-picker): prevent text selection when using color sliders/fi…
ab33e4d 
…eld (#10043)

**Related Issue:** #9977

## Summary

Restores prevention of text-selection when using the color
field/sliders.
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Aug 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned jcfranco Aug 13, 2024
@DitwanP
Copy link
Contributor

DitwanP commented Aug 13, 2024

🍡 Verified on 2.12.0-next.13
https://codepen.io/Ditwan-Price/pen/VwJrXRN?editors=1000

@DitwanP DitwanP closed this as completed Aug 13, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Charts Issues logged by ArcGIS Charts team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - high Issue should be addressed in the current milestone, impacts component or core functionality regression Issues that are caused by changes in a release, but were working before that.
Projects
None yet
Milestone
2024-08-27 - Aug Release
Development

No branches or pull requests
4 participants
@jcfranco @geospatialem @DitwanP @nel11211