Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(chromatic): ensure skip label added by ci works #10078

Merged
merged 2 commits into from
Aug 15, 2024
Merged

Conversation

benelan
Copy link
Member

@benelan benelan commented Aug 15, 2024

Related Issue: #10077

Summary

Events triggered by the default GITHUB_TOKEN will not create new workflow runs. We need the labelling to trigger the Chromatic workflow so it can skip the visual snapshots.

ref: https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/triggering-a-workflow#triggering-a-workflow-from-a-workflow

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@github-actions github-actions bot added the chore Issues with changes that don't modify src or test files. label Aug 15, 2024
@benelan benelan added the skip visual snapshots Pull requests that do not need visual regression testing. label Aug 15, 2024
@benelan benelan merged commit 76027f9 into dev Aug 15, 2024
10 checks passed
@benelan benelan deleted the benelan/chromatic-check branch August 15, 2024 23:16
@github-actions github-actions bot added this to the 2024-08-27 - Aug Release milestone Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issues with changes that don't modify src or test files. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants