Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dialog, panel): restore relative positioning in content area #10749

Merged
merged 1 commit into from
Nov 18, 2024
Merged

fix(dialog, panel): restore relative positioning in content area #10749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions packages/calcite-components/src/components/dialog/dialog.stories.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,16 +376,8 @@ const themedStyle = html`--calcite-dialog-scrim-background-color: purple; --calc
--calcite-dialog-content-space: 50px; --calcite-dialog-offset-x: 50px; --calcite-dialog-offset-y: -30px;`;

export const withShellInside = (): string =>
html`<calcite-dialog
open
modal
heading="heading"
description="description"
scale="m"
width-scale="l"
style="--calcite-dialog-content-space: 0;"
>
<calcite-shell style="position:relative">
html`<calcite-dialog open modal heading="heading" description="description" scale="m" width-scale="l">
<calcite-shell>
<calcite-shell-panel slot="panel-start">
<calcite-action-bar slot="action-bar" expanded>
<calcite-action-group>
Expand Down
3 changes: 2 additions & 1 deletion packages/calcite-components/src/components/panel/panel.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,8 @@
items-stretch
overflow-auto
h-full
focus-base;
focus-base
relative;
padding: var(--calcite-panel-content-space, 0);
background: var(--calcite-panel-background-color, var(--calcite-color-background));
}
Expand Down
Loading