Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(chip)!: make label property required and value optional #10787

Merged
merged 3 commits into from
Nov 23, 2024

Conversation

benelan
Copy link
Member

@benelan benelan commented Nov 19, 2024

Related Issue: #8696

Summary

  • Make the label property required to ensure it is provided to a11y assistive technologies.
  • Make the value property optional in favor of label.

BREAKING CHANGE: The label property is now required and value is optional.

@benelan benelan linked an issue Nov 19, 2024 that may be closed by this pull request
6 tasks
@github-actions github-actions bot added the refactor Issues tied to code that needs to be significantly reworked. label Nov 19, 2024
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@benelan benelan added the skip visual snapshots Pull requests that do not need visual regression testing. label Nov 22, 2024
@benelan benelan merged commit 31f0fe4 into dev Nov 23, 2024
12 checks passed
@benelan benelan deleted the benelan/8696-chip-label-prop-required branch November 23, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Issues tied to code that needs to be significantly reworked. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Chip] Ensure the label prop is provided to assistive technologies
2 participants