Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(combobox-item, combobox-item-group): update padding indentation for nested groups & items #10847

Merged
merged 8 commits into from
Dec 11, 2024
Merged

feat(combobox-item, combobox-item-group): update padding indentation for nested groups & items #10847

merged 8 commits into from
Dec 11, 2024

Conversation

anveshmekala
Copy link
Contributor

Related Issue: #7099

Summary

Updates padding indentation for nested combobox-item-group's & combobox-items's .

@anveshmekala anveshmekala added the visual changes Issues with visual changes that are added for consistency, but are not backwards compatible. label Nov 22, 2024
@github-actions github-actions bot added the enhancement Issues tied to a new feature or request. label Nov 22, 2024
@anveshmekala
Copy link
Contributor Author

Using feat here due to the visual changes.

cc @geospatialem

@anveshmekala anveshmekala marked this pull request as ready for review November 22, 2024 21:16
@anveshmekala anveshmekala added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Nov 22, 2024
@anveshmekala anveshmekala added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Nov 25, 2024
@anveshmekala anveshmekala added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Nov 26, 2024
@anveshmekala anveshmekala marked this pull request as draft November 26, 2024 17:40
@anveshmekala anveshmekala marked this pull request as ready for review November 26, 2024 22:53
@anveshmekala anveshmekala added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Nov 26, 2024
@anveshmekala anveshmekala added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Nov 26, 2024
ashetland
ashetland approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@ashetland ashetland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visual changes lookin' good!

@ashetland ashetland self-requested a review November 26, 2024 23:50
@ashetland
Copy link
Contributor

Can we add scale coverage to include Item Groups and nesting?

@anveshmekala anveshmekala added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Nov 27, 2024
@anveshmekala anveshmekala removed the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Dec 2, 2024
@anveshmekala anveshmekala added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Dec 2, 2024
driskull
driskull approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @anveshmekala ! 🦖

packages/calcite-components/src/components/combobox-item-group/combobox-item-group.scss Outdated
@@ -45,8 +39,7 @@
flex-1
border-b
font-bold;
padding-block: var(--calcite-combobox-item-spacing-unit-l);
padding-inline: var(--calcite-combobox-item-spacing-unit-s);
padding: var(--calcite-combobox-item-spacing-indent);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: maybe indent doesn't make sense in the var name anymore? Since it covers both inline and block?

packages/calcite-components/src/components/combobox-item/combobox-item.scss
padding-block: var(--calcite-combobox-item-spacing-unit-s);
padding-inline: var(--calcite-combobox-item-spacing-unit-l);
padding-inline-end: var(--calcite-combobox-item-spacing-indent);
padding-inline-start: var(--calcite-combobox-item-indent-value);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: difference between indent and indent-value? Maybe these could be renamed as well.

@anveshmekala anveshmekala added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Dec 11, 2024
ashetland
ashetland approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@ashetland ashetland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

g2g from design 🚀

@anveshmekala anveshmekala merged commit 83669cb into dev Dec 11, 2024
15 checks passed
@anveshmekala anveshmekala deleted the anveshmekala/7099-combobox-refactor-indentation branch December 11, 2024 17:59
@github-actions github-actions bot added this to the 2024-12-17 - Dec Milestone milestone Dec 11, 2024
benelan pushed a commit that referenced this pull request Feb 8, 2025
@anveshmekala @benelan
feat(combobox-item, combobox-item-group): update padding indentation …
c6ef5e3 
…for nested groups & items (#10847)

**Related Issue:** #7099 

## Summary

Updates padding indentation for nested `combobox-item-group`'s &
`combobox-items`'s .
@calcite-admin calcite-admin mentioned this pull request Feb 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driskull driskull driskull approved these changes

@ashetland ashetland ashetland approved these changes

@jcfranco jcfranco Awaiting requested review from jcfranco

@benelan benelan Awaiting requested review from benelan

@Elijbet Elijbet Awaiting requested review from Elijbet

Assignees

@anveshmekala anveshmekala

Labels
enhancement Issues tied to a new feature or request. pr ready for visual snapshots Adding this label will run visual snapshot testing. visual changes Issues with visual changes that are added for consistency, but are not backwards compatible.
Projects
None yet
Milestone
2024-12-17 - Dec Milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anveshmekala @ashetland @driskull