Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chip): provide label context to assistive technologies #10888

Merged
merged 4 commits into from
Nov 27, 2024

Conversation

geospatialem
Copy link
Member

@geospatialem geospatialem commented Nov 26, 2024

Related Issue: #8696

Summary

Provides context to the component's label property for JAWS and NVDA users using the "img" role, conveying content is delivered in a visual manner and should be accompanied with the required label property.

@geospatialem geospatialem self-assigned this Nov 26, 2024
@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Nov 26, 2024
@geospatialem geospatialem added the skip visual snapshots Pull requests that do not need visual regression testing. label Nov 26, 2024
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice! 🚀

@geospatialem geospatialem merged commit c468bf8 into dev Nov 27, 2024
10 of 11 checks passed
@geospatialem geospatialem deleted the geospatialem/8696-a11y-chip-label branch November 27, 2024 19:57
@github-actions github-actions bot added this to the 2024-12-17 - Dec Milestone milestone Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants