feat(block-section): add component tokens #11032
Merged
+113
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
enhancement
benelan
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
Code LGTM, will defer to @alisonailea and @ashetland for design feedback
packages/calcite-components/src/components/block-section/block-section.e2e.ts
Outdated
Show resolved
Hide resolved
packages/calcite-components/src/components/block-section/block-section.e2e.ts
Outdated
Show resolved
Hide resolved
packages/calcite-components/src/components/block-section/block-section.scss
Outdated
Show resolved
Hide resolved
|
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
github-actions
bot
added
the
Stale
alisonailea
approved these changes
Dec 23, 2024
Elijbet
added
pr ready for visual snapshots
github-actions
bot
added this to the 2025-01-30 - 3.0.0 Jan Breaking Change Release milestone
benelan
pushed a commit
that referenced
this pull request
Feb 8, 2025
**Related Issue:** #7180 ## Summary Adds the following subcomponent tokens (CSS props): - `--calcite-block-section-background-color` - `--calcite-block-section-border-color` - `--calcite-block-section-header-text-color` - `--calcite-block-section-text-color` - `--calcite-block-section-text-color-hover`
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #7180
Summary
Adds the following subcomponent tokens (CSS props):
--calcite-block-section-background-color--calcite-block-section-border-color--calcite-block-section-header-text-color--calcite-block-section-text-color--calcite-block-section-text-color-hover