ci(linting): fix typescript parser issue #11243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
chore
benelan
added
the
skip visual snapshots
|
pushing this through so stories can be committed, cc @jcfranco |
github-actions
bot
added this to the 2025-01-30 - 3.0.0 Jan Breaking Change Release milestone
Merged
benelan
added a commit
that referenced
this pull request
Jan 21, 2025
benelan
added a commit
that referenced
this pull request
Feb 8, 2025
## Summary Resolve a lint-staged error reported by @macandcheese: ```text ✖ eslint --fix: /Users/adam9519/Documents/git-repositories/calcite-design-system/packages/calcite-components/src/components/combobox/combobox.stories.ts 0:0 error Parsing error: /Users/adam9519/Documents/git-repositories/calcite-design-system/packages/calcite-components/src/components/combobox/combobox.stories.ts was not found by the project service. Consider either including it in the tsconfig.json or including it in allowDefaultProject ✖ 1 problem (1 error, 0 warnings) husky - pre-commit script failed (code 1) Hook process exited. ``` It seems like the projectService option is using `tsconfig.json` (which excludes stories) instead of `tsconfig-eslint.json`. Disabling the option for now. ref: https://typescript-eslint.io/getting-started/typed-linting/
benelan
added a commit
that referenced
this pull request
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolve a lint-staged error reported by @macandcheese:
It seems like the projectService option is using
tsconfig.json(which excludes stories) instead oftsconfig-eslint.json. Disabling the option for now.ref: https://typescript-eslint.io/getting-started/typed-linting/