Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(segmented-control, segmented-control-item): add component tokens #11359

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

driskull
Copy link
Member

Related Issue: #7180

Summary

Add segmented-control, segmented-control-item component tokens.

--calcite-segmented-control-color: Specifies the component's color.
--calcite-segmented-control-background-color: Specifies the component's background color.
--calcite-segmented-control-border-color: Specifies the component's border color.
--calcite-segmented-control-shadow: Specifies the component's shadow.
--calcite-segmented-control-icon-color: Specifies the icons's color.

@github-actions github-actions bot added the enhancement Issues tied to a new feature or request. label Jan 22, 2025
@driskull driskull marked this pull request as ready for review January 22, 2025 20:28
@driskull driskull added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Jan 23, 2025
@@ -40,15 +41,15 @@ describe("calcite-segmented-control-item", () => {
it("renders icon at start if requested", async () => {
const page = await newE2EPage();
await page.setContent(`
<calcite-segmented-control-item icon-start="car">Content</calcite-accordion-item>`);
<calcite-segmented-control-item icon-start="car">Content</calcite-segmented-control-item>`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

Copy link
Contributor

@alisonailea alisonailea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Matt looks great!

@driskull driskull merged commit 6f6a654 into dev Jan 29, 2025
18 checks passed
@driskull driskull deleted the dris0000/segmented-control-tokens branch January 29, 2025 18:49
benelan pushed a commit that referenced this pull request Feb 8, 2025
…#11359)

**Related Issue:** #7180

## Summary

Add `segmented-control`, `segmented-control-item` component tokens.

`--calcite-segmented-control-color`: Specifies the component's color.
`--calcite-segmented-control-background-color`: Specifies the
component's background color.
`--calcite-segmented-control-border-color`: Specifies the component's
border color.
`--calcite-segmented-control-shadow`: Specifies the component's shadow.
`--calcite-segmented-control-icon-color`: Specifies the icons's color.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issues tied to a new feature or request. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants