-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(segmented-control, segmented-control-item): add component tokens #11359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -40,15 +41,15 @@ describe("calcite-segmented-control-item", () => { | |||
it("renders icon at start if requested", async () => { | |||
const page = await newE2EPage(); | |||
await page.setContent(` | |||
<calcite-segmented-control-item icon-start="car">Content</calcite-accordion-item>`); | |||
<calcite-segmented-control-item icon-start="car">Content</calcite-segmented-control-item>`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹
macandcheese
approved these changes
Jan 27, 2025
alisonailea
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Matt looks great!
benelan
pushed a commit
that referenced
this pull request
Feb 8, 2025
…#11359) **Related Issue:** #7180 ## Summary Add `segmented-control`, `segmented-control-item` component tokens. `--calcite-segmented-control-color`: Specifies the component's color. `--calcite-segmented-control-background-color`: Specifies the component's background color. `--calcite-segmented-control-border-color`: Specifies the component's border color. `--calcite-segmented-control-shadow`: Specifies the component's shadow. `--calcite-segmented-control-icon-color`: Specifies the icons's color.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Issues tied to a new feature or request.
pr ready for visual snapshots
Adding this label will run visual snapshot testing.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #7180
Summary
Add
segmented-control
,segmented-control-item
component tokens.--calcite-segmented-control-color
: Specifies the component's color.--calcite-segmented-control-background-color
: Specifies the component's background color.--calcite-segmented-control-border-color
: Specifies the component's border color.--calcite-segmented-control-shadow
: Specifies the component's shadow.--calcite-segmented-control-icon-color
: Specifies the icons's color.