Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(date-picker): remove outline for header actions #11369

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

anveshmekala
Copy link
Contributor

@anveshmekala anveshmekala commented Jan 23, 2025

Related Issue: #11371

Summary

Removes outline for header actions which is causing transition on focus shift.

This is introduced with #10836 where outline exclusion from transition is ignored in Tailwind util.

BEGIN_COMMIT_OVERRIDE
omitted from changelog
END_COMMIT_OVERRIDE

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Jan 23, 2025
@anveshmekala anveshmekala added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Jan 23, 2025
@anveshmekala anveshmekala marked this pull request as ready for review January 23, 2025 17:18
@anveshmekala anveshmekala added the no changelog entry Use the commit override to avoid a changelog entry label Jan 23, 2025
Copy link
Member

@benelan benelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@anveshmekala anveshmekala merged commit b39b8ae into dev Jan 23, 2025
21 checks passed
@anveshmekala anveshmekala deleted the anveshmekala/fix-date-picker-outline-transition branch January 23, 2025 22:14
benelan added a commit that referenced this pull request Jan 24, 2025
* origin/dev: (34 commits)
  build: update browserslist db (#11339)
  build(deps): update dependency lint-staged to v15.4.1 (#11343)
  chore: release next
  feat(graph): add component tokens (#11355)
  chore: release next
  fix(popover, tooltip): drop relative-positioning to reduce risk of clipping (#11373)
  chore: release next
  fix(date-picker): no longer disable min/max value month in select menu (#11350)
  chore(icon): improve icon load error message (#11367)
  fix(date-picker): remove outline for header actions (#11369)
  chore: release next
  fix(carousel): Ensure correct `autoplay` display and animation (#11338)
  chore: release next
  fix(flow): process items on loaded (#11364)
  chore: release next
  fix(combobox, stepper, table): respect user hidden attribute (#10983)
  refactor(action-pad): restore rounded styling (#11358)
  test(combobox): avoid emitting change event for value property update (#11281)
  chore: release next
  refactor(action-pad): remove unnecessary overflow css styling. (#11349)
  ...
benelan pushed a commit that referenced this pull request Feb 8, 2025
**Related Issue:** #11371 

## Summary

Removes outline for header actions which is causing transition on focus
shift.

This is introduced with
#10836 where outline
exclusion from transition is ignored in Tailwind util.

BEGIN_COMMIT_OVERRIDE
omitted from changelog
END_COMMIT_OVERRIDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. no changelog entry Use the commit override to avoid a changelog entry pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants