Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(notice): consistent api refs #4661

Merged
merged 4 commits into from
May 31, 2022

Conversation

geospatialem
Copy link
Member

Related Issue: #4442

Summary

  • Consistent API style guide references for calcite-notice.
  • Note: Added a JSDoc optional tag for the dismissible property instead of using the "Optionally" supporting text.

@geospatialem geospatialem requested a review from a team as a code owner May 31, 2022 14:41
@github-actions github-actions bot added the docs Issues relating to documentation updates only. label May 31, 2022
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good @geospatialem !

src/components/notice/notice.tsx Outdated Show resolved Hide resolved
@geospatialem geospatialem merged commit 6443f95 into master May 31, 2022
@geospatialem geospatialem deleted the geospatialem/4442-notice-api-style-guide branch May 31, 2022 19:05
@github-actions github-actions bot added this to the Sprint 05/23 - 06/03 milestone May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Issues relating to documentation updates only.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants