Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(combobox): add support for placeholder icon & no longer display leading space for placeholder text #4784

Merged
merged 3 commits into from
Jun 29, 2022
Merged

feat(combobox): add support for placeholder icon & no longer display leading space for placeholder text #4784

merged 3 commits into from
Jun 29, 2022

Conversation

anveshmekala
Copy link
Contributor

@anveshmekala anveshmekala commented Jun 21, 2022 •
edited
Loading

Related Issue: #4629

Summary

  • Adds support for @Prop() placeholder-icon which leads placeholder text in calcite-combobox .

41D43904-F2C5-4D53-B373-5B1FA772FF5E_4_5005_c

  • This will fix the leading space added to the placeholder text in combobox when the combobox-item contains icon at start.

Before:

188DD29D-6F03-4F95-A778-BE936B02838C_4_5005_c

After the fix

0C14FD5E-329B-4598-A9AE-A36697EDC8BE_4_5005_c

@github-actions github-actions bot added the enhancement Issues tied to a new feature or request. label Jun 21, 2022
@anveshmekala anveshmekala marked this pull request as ready for review June 21, 2022 19:00
@anveshmekala anveshmekala requested a review from a team as a code owner June 21, 2022 19:00
driskull
driskull approved these changes Jun 27, 2022
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

src/components/combobox/combobox.tsx Outdated Show resolved Hide resolved
@anveshmekala anveshmekala merged commit 2c9f5e8 into master Jun 29, 2022
@anveshmekala anveshmekala deleted the anveshmekala/4629-combobox-add-placeholdericon-support branch June 29, 2022 15:51
@github-actions github-actions bot added this to the Sprint 06/27 - 07/08 milestone Jun 29, 2022
@SkyeSeitz SkyeSeitz removed their assignment Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driskull driskull driskull approved these changes

Assignees

@anveshmekala anveshmekala

Labels
enhancement Issues tied to a new feature or request.
Projects
None yet
Milestone
Sprint 06/27 - 07/08
Development

Successfully merging this pull request may close these issues.
3 participants
@anveshmekala @driskull @SkyeSeitz