Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: close past due milestone when its last issue is moved #5229

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

benelan
Copy link
Member

@benelan benelan commented Aug 26, 2022

Related Issue: #

Summary

We have a GitHub Action that closes a milestone when all of the issues are completed. Currently it is only triggered when an issue is closed. Sometimes an issue does not pass the QA verification and the issue needs to be moved to the current sprint or backburner. With this PR the milestone will properly close.

@benelan benelan requested a review from a team as a code owner August 26, 2022 21:01
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice!

@benelan benelan merged commit 3c56da7 into master Sep 2, 2022
@benelan benelan deleted the benelan/move-issue-close-milestone branch September 2, 2022 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants