ci(screener): clean up and exclude unnecessary stories #5257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ples to simple stories to eliminate it as a separate story
…ght and dark stories and renamaing to use simple
…nents into benelan/prune-stories
…nents into benelan/prune-stories
This was referenced Sep 7, 2022
ci(screener): trimming down stories for components starting with s - z to reduce snapshot load
#5263
Closed
eriklharper
pushed a commit
that referenced
this pull request
Sep 8, 2022
**Related Issue:** #5257 ## Summary Some additional cleanup. I nuked a lot of the combinations but we can add some back once we are out of crisis mode <!-- Please make sure the PR title and/or commit message adheres to the https://www.conventionalcommits.org/en/v1.0.0/ specification. Note: If your PR only has one commit and it is NOT semantic, you will need to either a. add another commit and wait for the check to update b. proceed to squash merge, but make sure the commit message is the same as the title. This is because of the way GitHub handles single-commit squash merges (see zeke/semantic-pull-requests#17) If this is component-related, please verify that: - [ ] feature or fix has a corresponding test - [ ] changes have been tested with demo page in Edge --- If this is skipping an unstable test: - include info about the test failure - submit an unstable-test issue by [choosing](https://github.com/Esri/calcite-components/issues/new/choose) the unstable test template and filling it out -->
driskull
reviewed
Sep 22, 2022
| dir="${select("dir", ["ltr", "rtl"], "ltr", "Tile Select Group")}" | ||
| class="calcite-theme-dark" | ||
| > | ||
| const tileSelectsHTML = html` |
There was a problem hiding this comment.
@benelan this needs to return a function. Otherwise, the knobs get applied to every story.
There was a problem hiding this comment.
@jcfranco is this payback for calling out the others, are you trying to pin this one on me??
There was a problem hiding this comment.
Sorry @benelan I just saw it was merged in that PR which was yours :)
There was a problem hiding this comment.
Franco is now banned from touching stories :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #5253
Summary
This PR cleanups up and combines stories to lower our snapshot count below 40k per month.
_NoTestto story names that we don't want screener to snapshot._TestOnlyto story names that we do not want to appear in the Storybook deployment on github pages.STORYBOOK_SCREENSHOT_TEST_BUILD. The default isNoTest, and the env var is set totruein thepr-screenerworkflow.darkThemeRTL_TestOnlysnapshot.