ci(screener): refine when screener runs on pull requests #5280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benelan
added
the
pr ready for visual snapshots
benelan
added
pr ready for visual snapshots
benelan
added
pr ready for visual snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #5253
Summary
This PR refines the PR linked above. Here are the conditions for when Screener runs on a PR:
pr ready for visual snapshotslabel is added to a normal PR (not draft PRs)pr ready for visual snapshotslabel is marked as "Ready to review"When someone pushes changes to a PR that has the
pr ready for visual snapshots label(meaning snapshots already ran), Screener will NOT run but it WILL show a green checkmark allowing the author to merge the PR. This is so that PRs can be merged w/o another Screener run if there are some small cleanups needed.If you need to rerun screener, remove and re-add the
pr ready for visual snapshotslabel.Screener will still run on every push to
master. This should provide a back up in case a visual regression slips through due to the point above. I will monitor the Screener runs onmasterwhile these limitations are in place.