fix(dropdown): fix calculation of max-items for non-Chromium browsers.

[jcfranco]

Related Issue: #5663

Summary

This fixes a regression caused by #5399 where the floating-ui element is placed offscreen and its styles change the offsetParent in non-Chromium browsers.

This codepen shows the difference when opened in Chromium vs non-Chromium browsers: https://codepen.io/jcfranco/pen/OJEMwzz?editors=1010

[driskull]

Nice! A one liner!

Guess we need to start getting screenshots on other browsers :)

[jcfranco]

Guess we need to start getting screenshots on other browsers :)

Yeah, we can reconsider expanding our coverage in the near future. Maybe for starters we can add screenshots for non-Chrome fixes? cc @benelan

[eriklharper]

Maybe for starters we can add screenshots for non-Chrome fixes? cc @benelan

+1

[benelan]

Yeah Chromatic supports Firefox, I'll look to see if there is a way to specify which browser to run on per snapshot

[eriklharper]

Yeah Chromatic supports Firefox, I'll look to see if there is a way to specify which browser to run on per snapshot

That would be very cool if that's possible.

[benelan]

Unfortunately it's not possible. We would have to run all snapshots on both chrome and firefox in order to add coverage for the non-Chrome fixes. Could be a candiate for our first official enhancement request

[eriklharper]

Unfortunately it's not possible. We would have to run all snapshots on both chrome and firefox in order to add coverage for the non-Chrome fixes. Could be a candiate for our first official enhancement request

Had a feeling that was the case. Certainly would make for a great experience though if we could add browser-specific snapshots since we do get reports on specific UI issues that would be excellent to capture with just a single or small set of very specific cases that are browser-specific. We should definitely request this feature.