Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(card)!: rename footer-leading and footer-trailing slots to footer-start and footer-end #6249

Merged
merged 1 commit into from
Jan 9, 2023
Merged

refactor(card)!: rename footer-leading and footer-trailing slots to footer-start and footer-end #6249

merged 1 commit into from
Jan 9, 2023

Conversation

benelan
Copy link
Member

@benelan benelan commented Jan 6, 2023

BREAKING CHANGE: rename footer-leading and footer-trailing slots to footer-start and footer-end

  • Removed footer-leading and footer-trailing slots, use footer-start and footer-end instead

@benelan benelan added the breaking change Issues and pull requests with code changes that are not backwards compatible. label Jan 6, 2023
@benelan benelan requested a review from eriklharper January 6, 2023 23:01
@benelan benelan requested a review from a team as a code owner January 6, 2023 23:01
@benelan benelan self-assigned this Jan 6, 2023
@github-actions github-actions bot added the refactor Issues tied to code that needs to be significantly reworked. label Jan 6, 2023
@benelan benelan mentioned this pull request Jan 6, 2023
Merged
anveshmekala
anveshmekala approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@anveshmekala anveshmekala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@anveshmekala anveshmekala added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Jan 9, 2023
@benelan benelan merged commit b508085 into master Jan 9, 2023
@benelan benelan deleted the benelan/6247-rename-card-slots branch January 9, 2023 19:55
@github-actions github-actions bot added this to the 2023 January Priorities milestone Jan 9, 2023
@jcfranco jcfranco mentioned this pull request Nov 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anveshmekala anveshmekala anveshmekala approved these changes

@eriklharper eriklharper Awaiting requested review from eriklharper

Assignees

@benelan benelan

Labels
breaking change Issues and pull requests with code changes that are not backwards compatible. pr ready for visual snapshots Adding this label will run visual snapshot testing. refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
2023 January Priorities
Development

Successfully merging this pull request may close these issues.
2 participants
@benelan @anveshmekala