Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(tabs): delay story due to potential timing chromatic diff #6437

Merged
merged 6 commits into from
Mar 8, 2023
Merged

test(tabs): delay story due to potential timing chromatic diff #6437

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2bd557b
test(tabs): delay story due to potential timing chromatic diff
benelan Feb 8, 2023
472441f
Merge branch 'master' into benelan/delay-tab-story
benelan Feb 8, 2023
f83ac11
Merge branch 'master' into benelan/delay-tab-story
benelan Mar 6, 2023
c6ada75
Merge remote-tracking branch 'origin/master' into benelan/delay-tab-s…
benelan Mar 7, 2023
8a18f06
chore: fix typo
benelan Mar 7, 2023
b503aec
Merge branch 'benelan/delay-tab-story' of github.com:esri/calcite-com…
benelan Mar 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/components/tabs/tabs.stories.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { optionsKnob, select } from "@storybook/addon-knobs";
import { select } from "@storybook/addon-knobs";
import { iconNames, storyFilters } from "../../../.storybook/helpers";
import { placeholderImage } from "../../../.storybook/placeholderImage";
import { modesDarkDefault } from "../../../.storybook/utils";
Expand Down Expand Up @@ -174,3 +174,6 @@ export const TabChilrenWithPercentageHeights = (): string => html`
</calcite-tab>
</calcite-tabs>
`;
TabChilrenWithPercentageHeights.parameters = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be spelled Children? ☝️

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chilrun 😂 Good catch.

chromatic: { delay: 1000 }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sidebar: I think we could extract this delay in a helper module for reuse.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I have it sprinkled around on other stories too. The only thing is I'd rather not delay all stories, only the ones we need to

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant extracting the delay value, so we would import the same reference.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha. I've been putting different delay values at this point to see what works without eating too much time. But once I figure that out I'll create a const

};