Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: set up focusable test helper to run a test per use case #6934

Merged

Conversation

Elijbet
Copy link
Contributor

@Elijbet Elijbet commented May 8, 2023

Related Issue: # N/A

Summary

Refactor focusable helper test helper to help mitigate timeouts.
The updated helper doc reflects how to use the helpers in E2E tests.

@github-actions github-actions bot added the testing Issues related to automated or manual testing. label May 8, 2023
@Elijbet Elijbet marked this pull request as ready for review May 9, 2023 06:42
@Elijbet Elijbet requested a review from a team as a code owner May 9, 2023 06:42
@Elijbet Elijbet added the skip visual snapshots Pull requests that do not need visual regression testing. label May 9, 2023
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks! 🎉

src/components/pick-list/shared-list-tests.ts Outdated Show resolved Hide resolved
src/components/pick-list/shared-list-tests.ts Outdated Show resolved Hide resolved
src/components/popover/popover.e2e.ts Outdated Show resolved Hide resolved
src/tests/commonTests.ts Outdated Show resolved Hide resolved
src/tests/commonTests.ts Outdated Show resolved Hide resolved
@Elijbet Elijbet merged commit 9b9eecf into master May 10, 2023
@Elijbet Elijbet deleted the elijbet/set-up-focusable-helper-to-stabilize-test-runs branch May 10, 2023 05:02
@github-actions github-actions bot added this to the 2023 May Priorities milestone May 10, 2023
alisonailea pushed a commit that referenced this pull request May 10, 2023
**Related Issue:** # N/A

## Summary

Refactor `focusable` helper test helper to help mitigate timeouts.
The updated helper doc reflects how to use the helpers in E2E tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip visual snapshots Pull requests that do not need visual regression testing. testing Issues related to automated or manual testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants