chore(eslint): disable jsdoc/require-param-type rule in favor of typescript #7326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benelan
requested review from
jcfranco,
driskull and
geospatialem
as code owners
github-actions
bot
added
the
chore
benelan
changed the title
benelan
added
the
skip visual snapshots
|
Sharing this from our convo for additional context: this will reduce linting noise we would get by not specifying the type in JSDoc, especially since the JSDoc type info isn't available in the build output. |
jcfranco
approved these changes
Jul 17, 2023
benelan
added a commit
that referenced
this pull request
Jul 18, 2023
…amping-ar-numberingsystem-bug * origin/main: chore(eslint): disable jsdoc/require-param-type rule in favor of typescript (#7326) style: lint and format code (#7319) chore: add editorconfig (#7318) chore: release next fix(input-date-picker): provides placeholder text context for AT users (#7320) chore: release next fix(dropdown-item): provides accessible label when href is not parsed (#7316) ci: create more specific codeowners to limit unnecessary notifications (#7313)
driskull
added a commit
that referenced
this pull request
Sep 15, 2023
**Related Issue:** None ## Summary Disables ESlint rule ["jsdoc/require-returns-type"](https://github.com/gajus/eslint-plugin-jsdoc/blob/main/docs/rules/require-returns-type.md#readme) since we rely on TypeScript. This builds upon #7326.
benelan
added a commit
that referenced
this pull request
Sep 18, 2023
**Related Issue:** #7747, #7326 ## Summary Disable [`jsdoc/require-property-type`](https://github.com/gajus/eslint-plugin-jsdoc/blob/main/docs/rules/require-property-type.md) in favor of using Typescript.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #7319
Summary
Disables the
jsdoc/require-param-typeeslint rule since we use TypeScript for that.