refactor(dropdown, dropdown-item-group, dropdown-item): getElementProp is refactored out in favor of inheritable props set directly on parent
#7582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p is refactored out across child components as an outdated pattern in favor of inheritable props set directly on parent
Elijbet
added
the
refactor
…pdown-item-group, so there can be a mix of types within one dropdown
Elijbet
added
the
pr ready for visual snapshots
Elijbet
added
pr ready for visual snapshots
driskull
approved these changes
Aug 24, 2023
packages/calcite-components/src/components/dropdown/dropdown.tsx
Outdated
Show resolved
Hide resolved
packages/calcite-components/src/components/dropdown-item/dropdown-item.tsx
Outdated
Show resolved
Hide resolved
packages/calcite-components/src/components/dropdown-item/dropdown-item.tsx
Outdated
Show resolved
Hide resolved
packages/calcite-components/src/components/dropdown-group/dropdown-group.tsx
Outdated
Show resolved
Hide resolved
packages/calcite-components/src/components/dropdown-group/dropdown-group.tsx
Outdated
Show resolved
Hide resolved
packages/calcite-components/src/components/dropdown-group/dropdown-group.tsx
Outdated
Show resolved
Hide resolved
Elijbet
changed the title
getElementProp is refactored out across child components as an outdated pattern in favor of inheritable props set directly on parentgetElementProp is refactored out in favor of inheritable props set directly on parent
Elijbet
added
skip visual snapshots
Elijbet
deleted the
origin/elijbet/6038-refactor-getElementProp-dropdown-item
branch
benelan
added a commit
that referenced
this pull request
Aug 25, 2023
…input * origin/main: refactor(segmented-control, segmented-control-item): `getElementProp` is refactored out in favor of inheritable props set directly on parent (#7592) chore: release next fix(loader): tweak loading animations to work in Safari (#7564) refactor(dropdown, dropdown-item-group, dropdown-item): `getElementProp` is refactored out in favor of inheritable props set directly on parent (#7582)
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #6038
Summary
getElementPropis refactored out across child components as an outdated pattern in favor of inheritable props set directly on the parent.The logic for setting these props thus moves to the parent, getting rid of the
getElementPropaltogether. The parent component gets amutationObserverto do this as well aswatchersfor when it needs to modify the children.Inherited props addressed:
scaleis inherited fromdropdown,selectionModeis inherited fromdropdown-item-group, so there can be a mix of types within one dropdown.