Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): bump @stencil/core #8266

Closed
wants to merge 3 commits into from
Closed

build(deps): bump @stencil/core #8266

wants to merge 3 commits into from

Conversation

jcfranco
Copy link
Member

Related Issue: N/A

Summary

🤜💥🤛

@github-actions github-actions bot added the chore Issues with changes that don't modify src or test files. label Nov 27, 2023
driskull
driskull approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jcfranco
Copy link
Member Author

The E2E check is failing due to a regression in E2EPage.find() where piercing selectors targeting non-existent elements throws an error. Created a Stencil issue for this: ionic-team/stencil#5113.

@benelan benelan changed the base branch from rc to main December 4, 2023 20:58
@benelan benelan requested a review from a team as a code owner December 4, 2023 20:58
@jcfranco jcfranco changed the base branch from main to rc December 6, 2023 07:35
@jcfranco jcfranco changed the base branch from rc to main December 6, 2023 07:35
@jcfranco jcfranco changed the base branch from main to rc December 6, 2023 07:36
@jcfranco
Copy link
Member Author

jcfranco commented Dec 6, 2023 •
edited
Loading

Recreating on main to pick up Stencil v4.8.1 and bypass conflict resolution. 😅

☝️ #8345

@jcfranco jcfranco closed this Dec 6, 2023
@jcfranco jcfranco deleted the jcfranco/bump-stencil branch December 6, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driskull driskull driskull approved these changes

@benelan benelan Awaiting requested review from benelan benelan is a code owner

@geospatialem geospatialem Awaiting requested review from geospatialem

Assignees

@jcfranco jcfranco

Labels
chore Issues with changes that don't modify src or test files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcfranco @driskull