Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(accordion, accordion-item): refactor for custom props #8637

Closed
wants to merge 6 commits into from

Conversation

alisonailea
Copy link
Contributor

Related Issue: #7180 #4060 #4012

Summary

Refactors accordion and accordion item for custom props and component tokens.

@alisonailea alisonailea added enhancement Issues tied to a new feature or request. refactor Issues tied to code that needs to be significantly reworked. design-tokens Issues requiring design tokens. labels Jan 24, 2024
@alisonailea alisonailea self-assigned this Jan 24, 2024
@alisonailea alisonailea requested a review from a team as a code owner January 24, 2024 19:19
Copy link
Contributor

@macandcheese macandcheese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions re: naming / strucutre

Copy link
Contributor

github-actions bot commented Feb 3, 2024

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Feb 3, 2024
@alisonailea alisonailea added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed Stale Issues or pull requests that have not had recent activity. labels Feb 8, 2024
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Feb 16, 2024
@alisonailea alisonailea removed the Stale Issues or pull requests that have not had recent activity. label Feb 16, 2024
@alisonailea alisonailea changed the title feat(accordion): refactor for custom props feat(accordion, accordion-item, accordion-item-group): refactor for custom props Feb 17, 2024
@alisonailea alisonailea changed the title feat(accordion, accordion-item, accordion-item-group): refactor for custom props feat(accordion, accordion-item): refactor for custom props Feb 17, 2024
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Feb 24, 2024
@alisonailea alisonailea deleted the astump/7180-accordion branch March 4, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-tokens Issues requiring design tokens. enhancement Issues tied to a new feature or request. pr ready for visual snapshots Adding this label will run visual snapshot testing. refactor Issues tied to code that needs to be significantly reworked. Stale Issues or pull requests that have not had recent activity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants