Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(block-section): add icon property (deprecates status) #9194

Merged
merged 29 commits into from
May 11, 2024
Merged

feat(block-section): add icon property (deprecates status) #9194

merged 29 commits into from
May 11, 2024

Conversation

Elijbet
Copy link
Contributor

@Elijbet Elijbet commented Apr 25, 2024 •
edited
Loading

Related Issue: #8110

Summary

Remove the status property and instead add an icon property.

Provide a demo and screenshot coverage.

@Elijbet Elijbet changed the title Elijbet/8110 block section deprecate status prop add icon prop feat(block-section): deprecate status property, add icon property instead Apr 25, 2024
@github-actions github-actions bot added the enhancement Issues tied to a new feature or request. label Apr 25, 2024
@Elijbet Elijbet marked this pull request as ready for review April 26, 2024 18:21
@Elijbet Elijbet requested a review from a team as a code owner April 26, 2024 18:21
@Elijbet Elijbet added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Apr 26, 2024
@Elijbet Elijbet added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Apr 26, 2024
jcfranco
jcfranco approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! A few things:

  • Let's target this for the May release. The token work might affect it and it'll also give more time for users to prep for the visual changes this will introduce.
  • Can you apply the visual changes to the issue?
  • Can you rephrase the PR title to be more along the lines of: feat(component): add X prop (deprecates Y)? We want to highlight the added prop first to align with the commit type.

packages/calcite-components/src/components/block-section/block-section.tsx Outdated Show resolved Hide resolved
packages/calcite-components/src/components/block-section/block-section.tsx Outdated
flipRtl={iconFlipRtl === "both" || iconFlipRtl === "start"}
icon={this.iconStart}
key="icon-start"
scale="s"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to use the getIconScale util?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

block/block-section don't have scale currently. It'll be reviewed in #7082. As is, we think of the components that don't have scale as medium and use small icons for them.

packages/calcite-components/src/components/block-section/block-section.tsx Outdated Show resolved Hide resolved
jcfranco
jcfranco approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! A few things:

  • Let's target this for the May release. The token work might affect it and it'll also give more time for users to prep for the visual changes this will introduce.
  • Can you apply the visual changes to the issue?
  • Can you rephrase the PR title to be more along the lines of: feat(component): add X prop (deprecates Y)? We want to highlight the added prop first to align with the commit type.

@Elijbet Elijbet changed the title feat(block-section): deprecate status property, add icon property instead feat(block-section): add icon property (deprecates status) Apr 29, 2024
jcfranco
jcfranco approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge once last round of changes are addressed. 🎉

packages/calcite-components/src/components/block-section/block-section.stories.ts Outdated Show resolved Hide resolved
packages/calcite-components/src/components/block-section/block-section.tsx Outdated Show resolved Hide resolved
packages/calcite-components/src/components/block-section/block-section.scss Outdated Show resolved Hide resolved
@Elijbet Elijbet added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels May 7, 2024
@Elijbet Elijbet added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels May 7, 2024
@Elijbet Elijbet added skip visual snapshots Pull requests that do not need visual regression testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels May 7, 2024
@Elijbet Elijbet merged commit c31bf36 into main May 11, 2024
10 checks passed
@Elijbet Elijbet deleted the elijbet/8110-block-section-deprecate-status-prop-add-icon-prop branch May 11, 2024 01:26
@calcite-admin calcite-admin mentioned this pull request May 11, 2024
Merged
@geospatialem geospatialem mentioned this pull request May 29, 2024
Closed
6 tasks
@jcfranco jcfranco mentioned this pull request May 30, 2024
Merged
jcfranco added a commit that referenced this pull request Jun 4, 2024
@jcfranco
fix(block-section): restore block toggling when clicking on the heade…
519a11c 
…r switch (#9472)

**Related Issue:** #9454

## Summary

Fixes toggling issue caused by moving switch outside toggle container.

This regression was introduced by #9194.
@jcfranco jcfranco mentioned this pull request Aug 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcfranco jcfranco jcfranco approved these changes

Assignees

@Elijbet Elijbet

Labels
enhancement Issues tied to a new feature or request. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Milestone
2024-05-28 - May Main Release
Development

Successfully merging this pull request may close these issues.
3 participants
@Elijbet @jcfranco @geospatialem