Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update placeholder images in stories and demos #9395

Merged
merged 1 commit into from
May 22, 2024
Merged

chore: Update placeholder images in stories and demos #9395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions packages/calcite-components/src/components/carousel/carousel.stories.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { select, number, text } from "../../../.storybook/fake-knobs";
import { modesDarkDefault } from "../../../.storybook/utils";
import { html } from "../../../support/formatting";
import { boolean } from "../../../.storybook/helpers";
import { placeholderImage } from "../../../.storybook/placeholderImage";

export default {
title: "Components/Carousel",
Expand Down Expand Up @@ -59,7 +60,7 @@ export const carouselAutoplayFullImageWithOverlayAndEdge = (): string =>
<style>
.bg-image-example {
color: red;
background-image: url("https://placebear.com/3000/2000");
background-image: url("${placeholderImage({ width: 3000, height: 2000 })}");
background-size: cover;
padding: 1rem;
height: 300px;
Expand Down Expand Up @@ -89,7 +90,7 @@ export const carouselAutoplayFullImageWithNoOverlay = (): string =>
<style>
.bg-image-example {
color: red;
background-image: url("https://placebear.com/3000/2000");
background-image: url("${placeholderImage({ width: 3000, height: 2000 })}");
background-size: cover;
padding: 1rem;
height: 300px;
Expand Down Expand Up @@ -119,7 +120,7 @@ export const carouselFullImageWithOverlay = (): string =>
<style>
.bg-image-example {
color: red;
background-image: url("https://placebear.com/3000/2000");
background-image: url("${placeholderImage({ width: 3000, height: 2000 })}");
background-size: cover;
padding: 1rem;
height: 300px;
Expand Down Expand Up @@ -203,7 +204,7 @@ export const themed_simple = (): string =>
<style>
.bg-image-example {
color: red;
background-image: url("https://placebear.com/3000/2000");
background-image: url("${placeholderImage({ width: 3000, height: 2000 })}");
background-size: cover;
padding: 1rem;
height: 300px;
Expand Down Expand Up @@ -264,7 +265,7 @@ export const themed_carouselFullImageWithOverlay = (): string =>
<style>
.bg-image-example {
color: red;
background-image: url("https://placebear.com/3000/2000");
background-image: url("${placeholderImage({ width: 3000, height: 2000 })}");
background-size: cover;
padding: 1rem;
height: 300px;
Expand Down
8 changes: 4 additions & 4 deletions packages/calcite-components/src/custom-theme.stories.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,16 +53,16 @@ export const themingInteractive = (): string => {
<div class="demo-column">
<calcite-accordion>
<calcite-accordion-item heading="Accordion Item"
><img src="https://placem.at/places?w=200&txt=0" />
><img src="${placeholderImage({ width: 300, height: 200 })}" />
</calcite-accordion-item>
<calcite-accordion-item heading="Accordion Item 2"
><img src="https://placem.at/places?w=200&txt=0" />
><img src="${placeholderImage({ width: 300, height: 200 })}" />
</calcite-accordion-item>
<calcite-accordion-item heading="Accordion Item 3"
><img src="https://placem.at/places?w=200&txt=0" />
><img src="${placeholderImage({ width: 300, height: 200 })}" />
</calcite-accordion-item>
<calcite-accordion-item heading="Accordion Item 4"
><img src="https://placem.at/places?w=200&txt=0" />
><img src="${placeholderImage({ width: 300, height: 200 })}" />
</calcite-accordion-item>
<calcite-accordion-item heading="Accordion Item 5" expanded>
<calcite-tree lines>
Expand Down
4 changes: 2 additions & 2 deletions packages/calcite-components/src/demos/carousel.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,13 +54,13 @@
}

.bg-image-example {
background-image: url("https://placebear.com/3000/2000");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch. Ill see if there are any more uses like this in CSS.

background-image: url("./_assets/images/placeholder.svg");
background-size: cover;
padding: 1.5rem 3rem;
height: 300px;
margin: 0;
font-size: 32px;
color: white;
color: red;
font-weight: 600;
line-height: 32px;
}
Expand Down
Loading