Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(assets): stringify list of paths for released packages #9451

Merged
merged 1 commit into from
May 30, 2024
Merged

ci(assets): stringify list of paths for released packages #9451

merged 1 commit into from
May 30, 2024

Conversation

benelan
Copy link
Member

@benelan benelan commented May 29, 2024

Related Issue: #9428

Summary

The new script for uploading release assets failed after 2.9.0 was deployed:

> calcite-design-system@0.0.0 util:upload-release-assets
2024-05-29T06:43:20.4633461Z > tsx support/uploadReleaseAssets.ts [packages/calcite-components,packages/calcite-components-react,packages/calcite-components-angular/projects/component-library]

SyntaxError: Unexpected token 'p', "[packages/c"... is not valid JSON
    at JSON.parse (<anonymous>)
    at <anonymous> (/home/runner/work/calcite-design-system/calcite-design-system/support/uploadReleaseAssets.ts:10:35)

The quotes were removed from the paths_released value, which should be valid, stringified JSON.

After some digging I came across a solution on stack overflow.

@github-actions github-actions bot added the chore Issues with changes that don't modify src or test files. label May 29, 2024
@jcfranco jcfranco added the skip visual snapshots Pull requests that do not need visual regression testing. label May 29, 2024
@benelan benelan merged commit da07197 into main May 30, 2024
9 checks passed
@benelan benelan deleted the benelan/release-assets-jsonify branch May 30, 2024 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alisonailea alisonailea alisonailea approved these changes

@jcfranco jcfranco jcfranco approved these changes

@driskull driskull Awaiting requested review from driskull

@geospatialem geospatialem Awaiting requested review from geospatialem geospatialem is a code owner

Assignees

@benelan benelan

Labels
chore Issues with changes that don't modify src or test files. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Milestone
2024-06-25 - Jun Release
Development

Successfully merging this pull request may close these issues.
3 participants
@benelan @jcfranco @alisonailea