Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(loader): simplify loader part rendering #9728

Merged
merged 3 commits into from
Jul 16, 2024

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Jul 3, 2024

Related Issue: N/A

Summary

Consolidates loader part rendering.

@jcfranco jcfranco added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Jul 3, 2024
@github-actions github-actions bot added the refactor Issues tied to code that needs to be significantly reworked. label Jul 3, 2024
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Jul 15, 2024
@jcfranco jcfranco marked this pull request as ready for review July 16, 2024 13:27
@jcfranco jcfranco requested a review from a team as a code owner July 16, 2024 13:27
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Jul 16, 2024
@jcfranco jcfranco merged commit 45aa451 into dev Jul 16, 2024
12 checks passed
@jcfranco jcfranco deleted the jcfranco/refactor-loader-part-rendering branch July 16, 2024 18:58
@github-actions github-actions bot added this to the 2024-07-30 - Jul Release milestone Jul 16, 2024
benelan added a commit that referenced this pull request Jul 16, 2024
* origin/dev: (61 commits)
  build: fix globby errors (#9797)
  chore: release next
  fix(deps): move @types/sortablejs as a dependency so the public types resolve properly (#9786)
  refactor(loader): simplify loader part rendering (#9728)
  chore: release next
  feat(combobox, combobox-item): add `description`, `shortHeading` props and `content-end` slot (#9771)
  docs: update component READMEs (#9735)
  chore: fix cleanup npm script (#9791)
  build: recreate lockfile due to build errors (#9790)
  style: autofix lint issues (#9789)
  chore: release next
  feat(panel, flow-item): add alerts slot (#9778)
  build(deps): update dependency lerna to v8.1.6 (#9679)
  build(deps): update dependency tslib to v2 (#9659)
  build(deps): update storybook monorepo to v8.2.2 (#9656)
  build(deps): update dependency tsx to v4.16.2 (#9642)
  build(deps): update amannn/action-semantic-pull-request action to v5.5.3 (#9712)
  build(deps): update dependency @esri/calcite-ui-icons to v3.29.0 (#9765)
  build(deps): update dependency @stencil/core to v4.19.2 (#9767)
  chore: release next
  ...
benelan added a commit that referenced this pull request Jul 19, 2024
…-to-monorepo

* origin/dev: (44 commits)
  build: update browserslist db (#9717)
  docs: update component READMEs (#9808)
  build(deps): update dependency rimraf to v5.0.9 (#9810)
  build(deps): update dependency prettier to v3.3.3 (#9809)
  build(deps): fix lerna install errors on osx machines (#9798)
  refactor(dropdown-item): remove unused members (#9794)
  test(combobox-item): add defaults and reflects tests (#9805)
  build(deps): update dependency globby to v14.0.2 (#9802)
  build(deps): update dependency postcss to v8.4.39 (#9803)
  build(deps): update dependency chromatic to v11.5.5 (#9800)
  build(deps): update dependency eslint-plugin-react to v7.34.4 (#9801)
  chore: remove codeowner team to reduce notifications (#9711)
  chore: release next
  fix(radio-button-group): remove blank clickable space outside of label (#9793)
  build: fix globby errors (#9797)
  chore: release next
  fix(deps): move @types/sortablejs as a dependency so the public types resolve properly (#9786)
  refactor(loader): simplify loader part rendering (#9728)
  chore: release next
  feat(combobox, combobox-item): add `description`, `shortHeading` props and `content-end` slot (#9771)
  ...
calcite-admin pushed a commit that referenced this pull request Jul 30, 2024
**Related Issue:** N/A

## Summary

Consolidates loader part rendering.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr ready for visual snapshots Adding this label will run visual snapshot testing. refactor Issues tied to code that needs to be significantly reworked. Stale Issues or pull requests that have not had recent activity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants