-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(loader): simplify loader part rendering #9728
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfranco
added
the
pr ready for visual snapshots
Adding this label will run visual snapshot testing.
label
Jul 3, 2024
github-actions
bot
added
the
refactor
Issues tied to code that needs to be significantly reworked.
label
Jul 3, 2024
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
github-actions
bot
added
the
Stale
Issues or pull requests that have not had recent activity.
label
Jul 15, 2024
driskull
approved these changes
Jul 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
jcfranco
added
pr ready for visual snapshots
Adding this label will run visual snapshot testing.
and removed
pr ready for visual snapshots
Adding this label will run visual snapshot testing.
labels
Jul 16, 2024
benelan
added a commit
that referenced
this pull request
Jul 16, 2024
* origin/dev: (61 commits) build: fix globby errors (#9797) chore: release next fix(deps): move @types/sortablejs as a dependency so the public types resolve properly (#9786) refactor(loader): simplify loader part rendering (#9728) chore: release next feat(combobox, combobox-item): add `description`, `shortHeading` props and `content-end` slot (#9771) docs: update component READMEs (#9735) chore: fix cleanup npm script (#9791) build: recreate lockfile due to build errors (#9790) style: autofix lint issues (#9789) chore: release next feat(panel, flow-item): add alerts slot (#9778) build(deps): update dependency lerna to v8.1.6 (#9679) build(deps): update dependency tslib to v2 (#9659) build(deps): update storybook monorepo to v8.2.2 (#9656) build(deps): update dependency tsx to v4.16.2 (#9642) build(deps): update amannn/action-semantic-pull-request action to v5.5.3 (#9712) build(deps): update dependency @esri/calcite-ui-icons to v3.29.0 (#9765) build(deps): update dependency @stencil/core to v4.19.2 (#9767) chore: release next ...
benelan
added a commit
that referenced
this pull request
Jul 19, 2024
…-to-monorepo * origin/dev: (44 commits) build: update browserslist db (#9717) docs: update component READMEs (#9808) build(deps): update dependency rimraf to v5.0.9 (#9810) build(deps): update dependency prettier to v3.3.3 (#9809) build(deps): fix lerna install errors on osx machines (#9798) refactor(dropdown-item): remove unused members (#9794) test(combobox-item): add defaults and reflects tests (#9805) build(deps): update dependency globby to v14.0.2 (#9802) build(deps): update dependency postcss to v8.4.39 (#9803) build(deps): update dependency chromatic to v11.5.5 (#9800) build(deps): update dependency eslint-plugin-react to v7.34.4 (#9801) chore: remove codeowner team to reduce notifications (#9711) chore: release next fix(radio-button-group): remove blank clickable space outside of label (#9793) build: fix globby errors (#9797) chore: release next fix(deps): move @types/sortablejs as a dependency so the public types resolve properly (#9786) refactor(loader): simplify loader part rendering (#9728) chore: release next feat(combobox, combobox-item): add `description`, `shortHeading` props and `content-end` slot (#9771) ...
calcite-admin
pushed a commit
that referenced
this pull request
Jul 30, 2024
**Related Issue:** N/A ## Summary Consolidates loader part rendering.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr ready for visual snapshots
Adding this label will run visual snapshot testing.
refactor
Issues tied to code that needs to be significantly reworked.
Stale
Issues or pull requests that have not had recent activity.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: N/A
Summary
Consolidates loader part rendering.