-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nested columns sometimes break due to rounding errors #742
Comments
I think an approach that would solve this would be to create a 1 column unit and use that for all column calculations. So:
|
I try your solution in my project and it'seem working find, but I work in less and I can use round function with decimal (http://lesscss.org/functions/#math-functions-round) for the value of col-unit. I can't find the same method in sass, but I found this : https://gist.github.com/terkel/4373420
|
Assigning to Tim. @tim-white-esri please feel free to reassign to your team members that have additional bandwidth. |
#742 - fix rounding error by making column max more even
will be fixed in the next relase |
The two
column-5
elements should fit into thecolumn-10
. But thecolumn-5
is rounding to302.08333px
. So302.08333 + 302.08333 = 604.16666
and thencolumn-10
is only604.16667px
. I think the browser is rounding these partial pixel values sometimes correctly, sometimes incorrectly.Could fix this by rounding all values to even pixels, maybe?
The text was updated successfully, but these errors were encountered: