Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing figcaption #827

Closed
jonathantneal opened this issue Jun 30, 2017 · 1 comment
Closed

Missing figcaption #827

jonathantneal opened this issue Jun 30, 2017 · 1 comment

Comments

@jonathantneal
Copy link
Contributor

At http://esri.github.io/calcite-web/examples/core/, I noticed the card examples use a figure element, but do not use a figcaption element even though the classname is caption. Is this on purpose?

<figure class="card-image-wrap">
	<img class="card-image" src="../../assets/img/docs/bridge3.jpg" alt="Bridge Club, 1954">
	<div class="card-image-caption">
		Florida, January 1954
	</div>
</figure>

Would you like a PR to change these to something like the following?

<figure class="card-image-wrap">
	<img class="card-image" src="../../assets/img/docs/bridge3.jpg" alt="Bridge Club, 1954">
	<figcaption class="card-image-caption">
		Florida, January 1954
	</figcaption>
</figure>
@paulcpederson
Copy link
Member

@jonathantneal not intentional, that would be a good change.

@paulcpederson paulcpederson self-assigned this Jul 17, 2017
@paulcpederson paulcpederson added this to the v1.0.0-rc.7 milestone Jul 17, 2017
paulcpederson added a commit to paulcpederson/calcite-web that referenced this issue Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants