Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table Tag #852

Closed
julio8a opened this issue Oct 17, 2017 · 12 comments
Closed

Table Tag #852

julio8a opened this issue Oct 17, 2017 · 12 comments
Assignees
Milestone

Comments

@julio8a
Copy link
Contributor

julio8a commented Oct 17, 2017

The fact that calcite web is directly taking ownership of the tag ‘table’ is really painful. It messes up with third-party library.This is a breaking change that we should take before calcite web 1.0 is released. This is really going to hurt a lot of apps if we don’t fix it now.

@paulcpederson
Copy link
Member

@julio8a I would tend to agree. Thinking a class applied to the root table element would be a good in-between.

@julio8a
Copy link
Contributor Author

julio8a commented Oct 18, 2017

The issue we're having is that table tag name and all children should not be modified by calcite.
If we want the table to be ‘calcite’, then we want to add a class like this:
<table class='table table-blue'></table>

@paulcpederson
Copy link
Member

paulcpederson commented Oct 18, 2017

Yep. That's what my comment was going for, sorry if I was unclear. I feel your pain on this issue, it caused a whole bunch of problems when styling dojo widgets as well (they use table layouts everywhere).

@julio8a
Copy link
Contributor Author

julio8a commented Oct 19, 2017

What would be the timeline for this change to take place in CW?

@paulcpederson
Copy link
Member

I'm pretty maxed out right now, but maybe @tim-white-esri could devote some cycles from his team on this? It's a pretty straight forward change, just needs to be documented.

@paulcpederson
Copy link
Member

I think this would be a good change. It's a breaking change, but I think it's the right call.

@jgrayson-apl
Copy link

jgrayson-apl commented Nov 8, 2017

I agree this would really help when using with the Esri JS API as I currently have several workarounds via JS to add the 'table-no-table' class to various use cases when esri js/dojo create tables on the fly (popups, legends, charts, etc). This workaround helps some, but doesn't solve everything. Also, table is not the only tag where this happens...

@paulcpederson
Copy link
Member

Yeah other styles are default typography (p, li, blockquote, h1...6, code).

@jgrayson-apl
Copy link

yep... 'label' is one that always causes issues, but dealing the 'table' will help a lot, so thank you.

@twhite313
Copy link

@paulcpederson Do you have this handled?

@paulcpederson
Copy link
Member

@tim-white-esri there is an open pr (#858) which I think just needs a little doc, but other than that should be good to go.

paulcpederson pushed a commit to paulcpederson/calcite-web that referenced this issue Apr 5, 2018
paulcpederson pushed a commit to paulcpederson/calcite-web that referenced this issue Apr 5, 2018
macandcheese pushed a commit that referenced this issue Apr 5, 2018
)

* #852 - table elements must now use .table class to receive styling ⚠️

* document $easing-function variable
@paulcpederson
Copy link
Member

this will be part of the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants