Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change implementation of drawer pattern #863

Closed
paulcpederson opened this issue Dec 1, 2017 · 2 comments
Closed

Change implementation of drawer pattern #863

paulcpederson opened this issue Dec 1, 2017 · 2 comments

Comments

@paulcpederson
Copy link
Member

Having the drawer push the wrapper over creates several problems (on mobile safari, and in preventing the use of position: sticky elsewhere on the page.

Should change so that the drawer slides over the wrapper. Make the following changes:

  1. remove transitions on wrapper
  2. remove overflow: hidden declaration on wrapper
  3. when drawer opens, add overflow: hidden to html element (this prevents scrolling in background)
@paulcpederson paulcpederson self-assigned this Dec 1, 2017
@paulcpederson paulcpederson added this to the v1 milestone Jan 18, 2018
paulcpederson added a commit to paulcpederson/calcite-web that referenced this issue Mar 9, 2018
@paulcpederson
Copy link
Member Author

will be part of next release

@asangma
Copy link
Collaborator

asangma commented Mar 10, 2018

bitmoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants