Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error with esc key handling in calcite.js #992

Closed
kellyhutchins opened this issue Nov 5, 2018 · 2 comments
Closed

Error with esc key handling in calcite.js #992

kellyhutchins opened this issue Nov 5, 2018 · 2 comments
Assignees
@paulcpederson
Labels
bug in development javascript
Milestone
1.2.0

Comments

@kellyhutchins
Copy link
Member

Looks like there is an issue in calcite-js with the key handling for the esc key.

Reproducible steps:

  1. Navigate to the content page on ArcGIS Online.
  2. Open the dev console and press the esc key and note the following error in the dev console:
    at main.js:3341
    at Array.forEach (<anonymous>)
    at g (main.js:3341)
    at b (main.js:3349)
    at F.emit (main.js:3368)
    at HTMLDocument.<anonymous> (main.js:3369)
@paulcpederson
Copy link
Member

Looks like this is related to the closeDrawer logic. When there is no drawer, the handler is still attached, so you get an error. Targeting next minor release.

@paulcpederson paulcpederson self-assigned this Nov 5, 2018
@paulcpederson paulcpederson added this to the 1.1.2 milestone Dec 6, 2018
paulcpederson added a commit to paulcpederson/calcite-web that referenced this issue Dec 7, 2018
@paulcpederson
Esri#992 - fix escape key error in calcite-web.js
99718f3
@paulcpederson
Copy link
Member

Fixed, will be part of 1.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paulcpederson paulcpederson

Labels
bug in development javascript
Projects
None yet
Milestone
1.2.0
Development

No branches or pull requests
2 participants
@paulcpederson @kellyhutchins