Introduces re-vamped AppContext & general architecture #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhdostal
approved these changes
Nov 10, 2020
There was a problem hiding this comment.
@esreli - This is great stuff. Nothing stood out to me as something that needed to be changed/modified. I really like the GlobalAlertQueue stuff as well as the new PortalSessionManager. I think both of those add a lot to the codebase.
As we talked about previously, some of the OfflineMapManager stuff may get modified/tweaked with the addition of preplanned work flows and maybe incorporation of the Toolkit's JobManager.
Nice stuff!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces an improved
AppContextstate-based architecture and more clear separation of responsibility. This architecture achieves more stability and resolves some found Portal related edge cases. Consult docs for more information.This PR comes with a bunch of architecture-adjacent improvements.