88-enterprise-support #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 20, 2021 10:04
Some VectorTileServer endpoints default to `f=html` which will break when the underlying mapbox-gl-js communicates with them and expects JSON in return.
gavinr
approved these changes
Jul 26, 2021
There was a problem hiding this comment.
Overall looks really great. I tested with an internal test Enterprise VTL and it seems to work fine.
A few minor questions:
- Do we have unit tests covering the optional custom style function? Is it easy to add one for that?
- For users who need to pass a token for a private Enterprise vector tile layer, should we include a sample or something (maybe just a link to https://esri.github.io/arcgis-rest-js/api/auth/generateToken/ ?)
|
Thanks for the review.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see commit history and new README documentation for more details.
resolves #88