This repository has been archived by the owner on May 23, 2022. It is now read-only.
Stand Alone Widget Deployment #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allows isolated deployment of widget
fixed missing join path
added missing file ext
Add theme generator
|
thanks for the contribution @mlewis22!
|
|
Sorry - I thought i was clever and moved it into a different branch. I forgot about the test! (Bad person). Ill take a look and put a new pull. |
Revert "Add theme generator"
Remove Theme
Standalone widget deployment
|
@gavinr -- updates to the code and readme so tests are now passing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Widget index.js has been improved. In addition to its current properties, developers can use this generator to create widgets in any folder location. This allows developers the flexibility to use the centralized widget templates without the extra requirement of having additional environmental setup such as a preconfigured task runner.
How?
When a user runs
yo esri-appbuilder-js:widgetThe code assess the current root project for a .yo-rc.json file. If it finds one it will continue to use the predefined properties currently utilized in the generator. If it doesn't, it will ask the user for a place to store the widgets. It will then offer the same options to the user when presented with initial project creation.
Why?
This use case has been generated to allow the creation of widgets inside a project that utilities docker and gulp. The project wanted to use the benefits of the generator without the restrictions of the initial project outlay. I felt it would be a useful low impact addition.