Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unify DCAT output #522

Closed
mhogeweg opened this issue Jan 31, 2024 · 3 comments
Closed

unify DCAT output #522

mhogeweg opened this issue Jan 31, 2024 · 3 comments
Assignees

Comments

@mhogeweg
Copy link
Member

Currently the output to DCAT format is different between the cached DCAT file and the output of the opensearch endpoint with f=dcat. The objective is to have both provide the same amount of detail per record (as much as possible).

@mhogeweg mhogeweg added the bug label Jan 31, 2024
@as0050629 as0050629 self-assigned this Feb 2, 2024
@as0050629
Copy link
Collaborator

as0050629 commented Feb 2, 2024

GeoportalSchema.buildAtomLinks (Line 150 to 171) - pushes the links with base url. In case of scheduled dcat task, links do not have baseURL so it is pushed as undefined/itemid .

DcatWriter validates that links are valid (isHrefValid) before adding in Distribution ( Line 91) , Since link is not valid, not added in distribution.

That is why in case of NOOA – only link added in distribution is from – GeoportalSchema : Line 173 (image)

DcatBuilder.java - Since it is a scheduler or process, httpServletRequest is not available and hence baseURL can not be calculated to be sent in requestInfo.

Added a new property baseUrl in app-dcat.xml - DcatBuilder

<beans:bean id="dcatBuilder" class="com.esri.geoportal.dcat.DcatBuilder">
<beans:constructor-arg ref="dcatCache"/>
<beans:property name="baseUrl" value="http://localhost:8080/geoportal" />
</beans:bean>

This needs to be modified as per environment

@as0050629
Copy link
Collaborator

@as0050629
Copy link
Collaborator

Merged in master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants