F/574 #599
Open
F/574 #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
work in progress
isEmpty() instead of == Null
via environment variables
as0050629
requested changes
Feb 10, 2025
| <beans:property name="awsAPIGatewayEndpoint" value=""/> --> | ||
| <beans:property name="engineType" value="${gpt_engineType:opensearch}"/> <!-- null | opensearch | elasticsearch --> | ||
| <beans:property name="awsOpenSearchType" value="${gpt_awsOpenSearchType}"/> <!-- null for all other types of Opensearch | serverless | managed --> | ||
| <beans:property name="awsOpenSearchRegion" value="${gpt_awsOpenSearchRegion}"/> <!-- null | valid AWS region --> |
There was a problem hiding this comment.
Since all environments will not use Amazon Opensearch serverless, properties related to serverless need to be commented by default , otherwise application will not start in absence of env variables. Please see app-context in master branch
There was a problem hiding this comment.
I have commented in default configuration
| type_unique ::= 'unique | ' <field_name> | ||
| type_intersects_collection ::= 'intersects_collection' | ||
| --> | ||
| <beans:value>${gpt_stacValidationRule1}</beans:value> |
There was a problem hiding this comment.
Are validation rules optional? then this also need to be commented in default config to avoid server start error. (In case env variable not present)
There was a problem hiding this comment.
I have commented in default configuration
as0050629
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
various STAC enhancements