test(): update and add test cases

Esri · Nov 15, 2024 · e680b3c · e680b3c
1 parent 44e403d
commit e680b3c
Show file tree

Hide file tree

Showing 4 changed files with 584 additions and 89 deletions.
diff --git a/packages/common/src/users/_internal/UserUiSchemaSettings.ts b/packages/common/src/users/_internal/UserUiSchemaSettings.ts
@@ -290,12 +290,10 @@ async function _getCommunityOrEnterpriseAGOUrl(
 export async function _getPortalSettings(
   context: IArcGISContext
 ): Promise<any> {
-  if (context.portal) {
-    // Fail safe fetch the portal settings
-    const fsGetPortalSettings = failSafe(getPortalSettings, {});
-    const settings = await fsGetPortalSettings(context.portal.id, {
-      portal: context.sharingApiUrl,
-    });
-    return settings;
-  }
+  // Fail safe fetch the portal settings
+  const fsGetPortalSettings = failSafe(getPortalSettings, {});
+  const settings = await fsGetPortalSettings(context.portal.id, {
+    portal: context.sharingApiUrl,
+  });
+  return settings;
 }
diff --git a/packages/common/src/users/_internal/computeProps.ts b/packages/common/src/users/_internal/computeProps.ts
@@ -29,11 +29,11 @@ export async function computeProps(
   const _portalself = await fsGetSelf(context.requestOptions);
   user.hubOrgSettings = {
     showInformationalBanner:
-      !!_portalself?.portalProperties?.hub?.settings?.informationalBanner,
-    enableTermsAndConditions: !!signinSettings?.termsAndConditions,
-    termsAndConditions: signinSettings?.termsAndConditions,
-    enableSignupText: !!signinSettings?.signupText,
-    signupText: signinSettings?.signupText,
+      !!_portalself.portalProperties?.hub?.settings?.informationalBanner,
+    enableTermsAndConditions: !!signinSettings.termsAndConditions,
+    termsAndConditions: signinSettings.termsAndConditions,
+    enableSignupText: !!signinSettings.signupText,
+    signupText: signinSettings.signupText,
   };
 
   return user;