Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Lerna 3 and/or use hoisting? #363

Closed
tomwayson opened this issue Sep 4, 2020 · 0 comments · Fixed by #381
Closed

Update to Lerna 3 and/or use hoisting? #363

tomwayson opened this issue Sep 4, 2020 · 0 comments · Fixed by #381

Comments

@tomwayson
Copy link
Member

It seems like lerna's hoisting could solve the problem of not being able to symlink hub.js packages b/c the postinstall step fails due to missing devDependencies.

Also, lerna 3 has been out for years now and the upgrade seems fairly painless. We should upgrade.
@tomwayson tomwayson mentioned this issue Sep 18, 2020
Closed
tomwayson added a commit that referenced this issue Sep 18, 2020
@tomwayson
chore(lerna): hoist package dependencies to the root; add script to c…
19e8c60 
…lean dependencies

affects: @esri/hub-annotations, @esri/hub-common, @esri/hub-content, @esri/hub-downloads,
@esri/hub-events, @esri/hub-initiatives, @esri/hub-search, @esri/hub-sites, @esri/hub-surveys,
@esri/hub-teams, @esri/hub-types

ISSUES CLOSED: #363
@tomwayson tomwayson mentioned this issue Sep 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

C/lerna hoist Esri/hub.js
1 participant
@tomwayson