Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add new item types from AGO to collections #1724

Merged
merged 9 commits into from
Nov 15, 2024
Merged

Conversation

vivzhang
Copy link
Contributor

@vivzhang vivzhang commented Nov 7, 2024

affects: @esri/hub-common

  1. Description:

Add new item types we pulled from AGO to collections

  1. Instructions for testing:

  2. Closes Issues: # (if appropriate)

  3. Updated meaningful TSDoc to methods including Parameters and Returns, see Documentation Guide

  4. used semantic commit messages

  5. PR title follows semantic commit format (CRITICAL if the title is not in a semantic format, the release automation will not run!)

  6. updated peerDependencies as needed. CRITICAL our automated release system can not be counted on to update peerDependencies so we must do it manually in our PRs when needed. See the updating peerDependencies section of the release instructions for more details.

affects: @esri/hub-common
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (2626a26) to head (d808f12).
Report is 160 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##            master     #1724    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          992      1030    +38     
  Lines        17979     18665   +686     
  Branches      3199      3377   +178     
==========================================
+ Hits         17979     18665   +686     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

There hasn't been any activity on this pull request in the past 3 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. If you want this PR to never become stale, please apply the "Draft" label.

@github-actions github-actions bot added the Stale Stale issue - update or it will be closed label Nov 12, 2024
packages/common/src/types.ts Outdated Show resolved Hide resolved
@vivzhang vivzhang changed the title fix: add a new ItemTypes array fix: add new item types from AGO to collections Nov 13, 2024
@github-actions github-actions bot removed the Stale Stale issue - update or it will be closed label Nov 14, 2024
affects: @esri/hub-common
@vivzhang vivzhang merged commit c87c8ef into master Nov 15, 2024
5 checks passed
@vivzhang vivzhang deleted the f/new-ItemTypes branch November 15, 2024 23:22
esri-dcdev-2 pushed a commit that referenced this pull request Nov 15, 2024
## @esri/hub-common [15.6.1](https://github.com/Esri/hub.js/compare/@esri/hub-common@15.6.0...@esri/hub-common@15.6.1) (2024-11-15)

### Bug Fixes

* add new item types from AGO to collections ([#1724](#1724)) ([c87c8ef](c87c8ef))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants