feat(hub-common): added dcat us template #1736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There hasn't been any activity on this pull request in the past 3 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. If you want this PR to never become stale, please apply the "Draft" label. |
sonofflynn89
approved these changes
Nov 22, 2024
sonofflynn89
approved these changes
Nov 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1736 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 992 1028 +36
Lines 17979 18705 +726
Branches 3199 3394 +195
==========================================
+ Hits 17979 18705 +726 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
esri-dcdev-2
pushed a commit
that referenced
this pull request
Nov 22, 2024
# @esri/hub-common [15.12.0](https://github.com/Esri/hub.js/compare/@esri/hub-common@15.11.0...@esri/hub-common@15.12.0) (2024-11-22) ### Features * **hub-common:** added dcat us template ([#1736](#1736)) ([651d04c](651d04c))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This PR adds DCAT US 3 template and make necessary changes to remove
getFeedConfigurationandsetFeedConfigurationin future by migrating their logics togetFeedTemplateandsetFeedTemplaterespectively.Instructions for testing:
Closes Issues: https://devtopia.esri.com/dc/hub/issues/11798
Updated meaningful TSDoc to methods including Parameters and Returns, see Documentation Guide
used semantic commit messages
PR title follows semantic commit format (CRITICAL if the title is not in a semantic format, the release automation will not run!)
updated
peerDependenciesas needed. CRITICAL our automated release system can not be counted on to updatepeerDependenciesso we must do it manually in our PRs when needed. See the updating peerDependencies section of the release instructions for more details.