Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

streamline UMD builds #487

Merged
merged 2 commits into from
Mar 14, 2021
Merged

streamline UMD builds #487

merged 2 commits into from
Mar 14, 2021

Conversation

tomwayson
Copy link
Member

@tomwayson tomwayson commented Mar 13, 2021

  • change UMD to build to use ESM output instead of TS source and remove @rollup/plugin-typescript
  • only run UMD build when preparing to release (instead of after installs, in CI, etc)

This cuts down the time it takes to run bootstrap from ~2:45 to ~1:05!!!

@codecov
Copy link

codecov bot commented Mar 13, 2021

Codecov Report

Merging #487 (f48ea83) into master (ed01776) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #487   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          424       424           
  Lines         5774      5774           
  Branches       874       874           
=========================================
  Hits          5774      5774           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed01776...f48ea83. Read the comment docs.

@tomwayson tomwayson changed the title change UMD to build to use ESM output instead of TS source streamline UMD builds Mar 13, 2021
@drewdaemon
Copy link
Contributor

drewdaemon commented Mar 14, 2021

@tomwayson Nice! I like removing the UMD build from the bootstrap process. That will make working in Hub.js much more ergonomic.

However, since you've done that, do we really need to use the ESM build as the input for the UMD build or would it be beneficial to keep them on separate TS compilation routes? Wouldn't that allow us to just bump the ESM build target to es2017 at the next major release without affecting the UMD (or requiring two versions of the ESM build)?

@tomwayson
Copy link
Member Author

Thanks @andrewctate, re:

Wouldn't that allow us to just bump the ESM build target to es2017 at the next major release without affecting the UMD (or requiring two versions of the ESM build)

Yes, but, there won't be a time when we'll be doing an UMD build but not an ESM ES5 build. Think of the UMD build being useful to a subset of consumers that could use the ESM ES5 build. So might as well use the ESM ES5 build as the input for the UMD build. Hopefully the plan I laid out #488 helps clarify that.

@tomwayson tomwayson merged commit 09fdd1b into master Mar 14, 2021
@tomwayson tomwayson deleted the c/no-rollup-typescript branch March 14, 2021 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants