Dispatches ui update to main queue #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philium
suggested changes
Oct 19, 2019
| @@ -24,7 +24,9 @@ extension MapViewController { | |||
|
|
|||
| mapView.locationDisplay.autoPanModeChangedHandler = { newAutoPanMode in | |||
| print("New autoPanMode: \(newAutoPanMode)") | |||
| self.gpsButton.setImage(self.mapView.locationDisplay.getImage(), for: .normal) | |||
| DispatchQueue.main.async { | |||
There was a problem hiding this comment.
I realize the map is always displayed (and therefore never goes away?), but for the sake of correctness, the autoPanModeChangedHandler should weakly capture self.
mhdostal
approved these changes
Oct 21, 2019
philium
approved these changes
Oct 21, 2019
philium
approved these changes
Oct 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In testing the app built for iOS 13, a runtime error was encountered. This PR addresses that error.
#89