-
Notifications
You must be signed in to change notification settings - Fork 322
Conversation
gavinr
commented
Aug 14, 2017
•
edited
Loading
edited
- Removed conflicts from the changes from @jwoyame Copy original HTTP request headers, #175 #186. (Forward request headers #175)
- Also making sure the list of headers that are in Proxies should not return hop-by-hop header fields #362 are not passed along.
Thanks @gavinr :) This PR has quite a few changes and potential for breaking unexpected things with the header changes. I tested it successfully with my 26 test cases. @MikeTschudi @jgravois et al - it'd be great and if you could also review/test. I plan to merge this PR if I don't hear anything the next few days... |
I remember we started passing thru all header value in the past during this issue #87 , Header, "Content-Disposition". @bsvensson does any of your 26 test cases cover attachment scenario per issue #87 ? If it does, we should be good. |
No. |
@gavinr, some questions and comments about the DotNet flavor, please.
|
comments from PR
Thanks @MikeTschudi - those changes have been made. Please take a look to make sure I have completed them in alignment with what you were thinking. |
@gavinr, thanks! |
Thanks @jwoyame @gavinr @MikeTschudi |